fix(#113): Adds regex to random.word to trim unwanted characters
#218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vigilant-wescoff-04e480 ready! 🔨 Explore the source changes: cee82f2 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e8394966b83e00084ebed9 😎 Browse the preview: https://deploy-preview-218--vigilant-wescoff-04e480.netlify.app |
MilosPaunovic
previously approved these changes
Jan 18, 2022
|
I still don't like this implementation. It feels kludgy. I would prefer a separate dataset rather than a regex. |
prisis
force-pushed
the
feature/sanitize-random-word2
branch
from
9702e32 to
cee82f2
Compare
|
Would this change hit performance of generating random data? I am little bit worried of calling regex like this. |
|
I think we have now 2 different (with me 3) that don't really like this PR 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rebase on #115 didnt work...