Skip to content

test: prepare test sources for strict mode #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

Shinigami92
Copy link
Member

extracted #2102

@Shinigami92 Shinigami92 self-assigned this Apr 28, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 28, 2023 15:16
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #2107 (d304773) into next (1cadfb9) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d304773 differs from pull request most recent head d1da1f6. Consider uploading reports for the commit d1da1f6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2107      +/-   ##
==========================================
- Coverage   99.60%   99.58%   -0.02%     
==========================================
  Files        2605     2567      -38     
  Lines      244944   243371    -1573     
  Branches     1254     1243      -11     
==========================================
- Hits       243967   242352    -1615     
- Misses        950      992      +42     
  Partials       27       27              

see 71 files with indirect coverage changes

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Apr 28, 2023
ST-DDT
ST-DDT previously approved these changes Apr 29, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Apr 29, 2023

Please amend the title or description to include at least the intention of this PR before merging this.
So we are inclusive to our community that wasn't present in our private conversation where we talked about this change.

E.g. This fixes some issues preventing the use of strict for our test sources
or prepare test sources for strict mode

@ST-DDT ST-DDT requested review from a team April 29, 2023 12:12
@Shinigami92 Shinigami92 changed the title test: improve tests test: prepare test sources for strict mode May 2, 2023
@ST-DDT ST-DDT requested review from a team May 2, 2023 14:32
@Shinigami92 Shinigami92 merged commit ede6ffa into next May 3, 2023
@Shinigami92 Shinigami92 deleted the improve-tests branch May 3, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants