refactor(company): remove English locale definitions from company in non-English locales #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmayer
changed the title
matthewmayer
added
c: chore
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2027 +/- ##
==========================================
- Coverage 99.62% 99.61% -0.01%
==========================================
Files 2563 2545 -18
Lines 243278 241648 -1630
Branches 1284 1284
==========================================
- Hits 242356 240717 -1639
- Misses 895 904 +9
Partials 27 27
|
ST-DDT
approved these changes
Apr 6, 2023
pkuczynski
approved these changes
Apr 6, 2023
|
|
Shinigami92
changed the title
Shinigami92
approved these changes
Apr 9, 2023
|
Feel free to edit the title I am no good at picking good PR titles. |
glad AIs getting better and better 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smaller version of #1935
removes only duplicate values of faker.company.* definitions where they are just duplicates of English, in non-English locales