Skip to content

test(finance): remove debug code from test #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2023
Merged

test(finance): remove debug code from test #1998

merged 2 commits into from
Mar 31, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 30, 2023 

version: v18.15.0 5496960535605138 16
version: v18.15.0 5487725794578560 16
version: v18.15.0 6759841867249615949 19
version: v18.15.0 6398767890152912 16
version: v18.15.0 6759832084026976 16

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test m: finance Something is referring to the finance module labels Mar 30, 2023
@ST-DDT ST-DDT requested review from a team March 30, 2023 17:02
@ST-DDT ST-DDT self-assigned this Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (next@a036b84). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2f3335a differs from pull request most recent head 6772f77. Consider uploading reports for the commit 6772f77 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1998   +/-   ##
=======================================
  Coverage        ?   99.62%           
=======================================
  Files           ?     2464           
  Lines           ?   240210           
  Branches        ?     1279           
=======================================
  Hits            ?   239312           
  Misses          ?      875           
  Partials        ?       23

@ST-DDT ST-DDT requested a review from a team March 30, 2023 17:28
@ST-DDT ST-DDT enabled auto-merge (squash) March 31, 2023 11:03
@ST-DDT ST-DDT merged commit f5eddaa into next Mar 31, 2023
@ST-DDT ST-DDT deleted the chore/finance/remove-debug-code branch March 31, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: test m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@ST-DDT @matthewmayer @Shinigami92 @xDivisionByZerox