Skip to content

docs: mark method references in @deprecation messages #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 22, 2023

All other method references use faker.x.y(), so I adjusted these to match the other ones.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 22, 2023
@ST-DDT ST-DDT requested review from a team March 22, 2023 20:29
@ST-DDT ST-DDT self-assigned this Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1963 (0ef7759) into next (4a3a6b9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0ef7759 differs from pull request most recent head ec13dd9. Consider uploading reports for the commit ec13dd9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1963      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files        2450     2384      -66     
  Lines      239449   238991     -458     
  Branches     1230     1228       -2     
==========================================
- Hits       238569   238109     -460     
- Misses        858      860       +2     
  Partials       22       22              
Impacted Files Coverage Δ
src/modules/datatype/index.ts 100.00% <100.00%> (ø)
src/modules/random/index.ts 100.00% <100.00%> (ø)

... and 122 files with indirect coverage changes

@xDivisionByZerox
Copy link
Member

What exactly does this PR try to achieve? Make all @deprecated calls look the same? Or only code styling?

@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 22, 2023

Standardization.

Search: @deprecated Use `faker -> Results: 66
Search: @deprecated Use faker -> Results: 6

@ST-DDT ST-DDT requested a review from a team March 22, 2023 22:16
@ST-DDT ST-DDT requested review from a team March 24, 2023 09:07
@ST-DDT ST-DDT enabled auto-merge (squash) March 27, 2023 11:28
@ST-DDT ST-DDT merged commit 87a5ba9 into next Mar 27, 2023
@ST-DDT ST-DDT deleted the docs/deprecated/mark-method-references branch March 27, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants