docs(internet): password doesn't create crypto-secure PWs #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
approved these changes
Mar 22, 2023
ST-DDT
added
c: docs
Shinigami92
previously approved these changes
Mar 22, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1961 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2384 2384
Lines 238991 238992 +1
Branches 1231 1232 +1
=======================================
+ Hits 238118 238121 +3
+ Misses 851 849 -2
Partials 22 22
|
xDivisionByZerox
previously approved these changes
Mar 22, 2023
ST-DDT
requested changes
Mar 23, 2023
deltamualpha
dismissed stale reviews from xDivisionByZerox and Shinigami92
via
df4ab4d
Since this API uses faker.number, which itself is just using a Mersenne Twister implementation, these passwords are not safe for use in cryptographically-sensitive contexts.
ST-DDT
approved these changes
Mar 23, 2023
ST-DDT
requested review from
Shinigami92,
xDivisionByZerox,
matthewmayer and
a team
xDivisionByZerox
changed the title
xDivisionByZerox
changed the title
xDivisionByZerox
approved these changes
Mar 23, 2023
Shinigami92
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this API uses faker.number, which itself is just using a Mersenne Twister implementation, these passwords are not safe for use in cryptographically-sensitive contexts.