Skip to content

infra: run generate scripts first #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2023
Merged

infra: run generate scripts first #1933

merged 1 commit into from
Mar 15, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 14, 2023

Changes the preflight script to first generate the files before trying to format/lint them.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Mar 14, 2023
@ST-DDT ST-DDT requested review from a team March 14, 2023 21:44
@ST-DDT ST-DDT self-assigned this Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1933 (f3013ef) into next (7e19224) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1933      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2357     2357              
  Lines      236815   236815              
  Branches     1225     1223       -2     
==========================================
- Hits       235943   235934       -9     
- Misses        850      859       +9     
  Partials       22       22              

see 2 files with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team March 14, 2023 22:02
@Shinigami92 Shinigami92 merged commit 2030cf1 into next Mar 15, 2023
@Shinigami92 Shinigami92 deleted the infra/generate-first branch March 15, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants