Skip to content

fix: consistent locale names #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2023
Merged

fix: consistent locale names #1884

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d0ec4d
fix: consistent locale names
ST-DDT Feb 28, 2023
0609903
Merge branch 'next' into fix/consistent-locale-names
ST-DDT Mar 7, 2023
965d9b6
Merge branch 'next' into fix/consistent-locale-names
ST-DDT Mar 7, 2023
49de925
docs: more changes
ST-DDT Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/guide/localization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,15 @@ export const customFaker = new Faker({
| `en_GH` | English (Ghana) | `fakerEN_GH` |
| `en_IE` | English (Ireland) | `fakerEN_IE` |
| `en_IN` | English (India) | `fakerEN_IN` |
| `en_NG` | Nigeria (English) | `fakerEN_NG` |
| `en_NG` | English (Nigeria) | `fakerEN_NG` |
| `en_US` | English (United States) | `fakerEN_US` |
| `en_ZA` | English (South Africa) | `fakerEN_ZA` |
| `es` | Spanish | `fakerES` |
| `es_MX` | Spanish (Mexico) | `fakerES_MX` |
| `fa` | Farsi | `fakerFA` |
| `fi` | Finnish | `fakerFI` |
| `fr` | French | `fakerFR` |
| `fr_BE` | Français (Belgique) | `fakerFR_BE` |
| `fr_BE` | French (Belgium) | `fakerFR_BE` |
| `fr_CA` | French (Canada) | `fakerFR_CA` |
| `fr_CH` | French (Switzerland) | `fakerFR_CH` |
| `fr_LU` | French (Luxembourg) | `fakerFR_LU` |
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/definitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export interface Definitions {
*/
export type LocaleDefinition = {
/**
* The name of the language.
* The English name of the language (and the specific country, if defined).
*/
title: string;
} & LocaleEntry<Definitions>;
2 changes: 1 addition & 1 deletion src/locales/en_NG/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import person from './person';
import phone_number from './phone_number';

const en_NG: LocaleDefinition = {
title: 'Nigeria (English)',
title: 'English (Nigeria)',
company,
internet,
location,
Expand Down
2 changes: 1 addition & 1 deletion src/locales/fr_BE/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import person from './person';
import phone_number from './phone_number';

const fr_BE: LocaleDefinition = {
title: 'Français (Belgique)',
title: 'French (Belgium)',
cell_phone,
internet,
location,
Expand Down