Skip to content

test(date): add birthdate error test #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2023
Merged

test(date): add birthdate error test #1833

merged 2 commits into from
Feb 14, 2023

Conversation

PeterYinusa
Copy link
Contributor

Adds a birthdate test that throws an error when the min is larger than the max year.

@PeterYinusa PeterYinusa requested a review from a team as a code owner February 13, 2023 21:09
@ejcheng ejcheng requested a review from a team February 13, 2023 22:16
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1833 (3008ccc) into next (de0768c) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1833   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2346     2346           
  Lines      235735   235735           
  Branches     1139     1144    +5     
=======================================
+ Hits       234865   234883   +18     
+ Misses        848      830   -18     
  Partials       22       22           
Impacted Files Coverage Δ
src/modules/date/index.ts 100.00% <0.00%> (+0.20%) ⬆️
src/modules/location/index.ts 98.91% <0.00%> (+0.21%) ⬆️
src/modules/internet/user-agent.ts 94.08% <0.00%> (+4.14%) ⬆️

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: date Something is referring to the date module labels Feb 13, 2023
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you for the contibution!

@ST-DDT ST-DDT enabled auto-merge (squash) February 13, 2023 23:38
@ST-DDT ST-DDT requested review from Shinigami92 and a team February 13, 2023 23:39
@ST-DDT ST-DDT merged commit 8f2d5c8 into faker-js:next Feb 14, 2023
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test m: date Something is referring to the date module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants