fix(person): avoid repeated last name via new last_name_patterns

src/definitions/person.ts

@@ -30,6 +30,11 @@ export type PersonDefinitions = LocaleEntry<{
    */
   name: Array<{ value: string; weight: number }>;
 
+  /**
+   * A weighted list of patterns used to generate last names.
+   */
+  last_name_patterns?: Array<{ value: string; weight: number }>;
+
   bio_patterns?: string[];
 
   title: PersonTitleDefinitions;

src/locales/en_GH/person/index.ts

@@ -6,13 +6,15 @@ import type { PersonDefinitions } from '../../..';
 import female_first_name from './female_first_name';
 import first_name from './first_name';
 import last_name from './last_name';
+import last_name_patterns from './last_name_patterns';
 import male_first_name from './male_first_name';
 import name_ from './name';
 
 const person: PersonDefinitions = {
   female_first_name,
   first_name,
   last_name,
+  last_name_patterns,
   male_first_name,
   name: name_,
 };

src/locales/en_GH/person/last_name_patterns.ts

@@ -0,0 +1,4 @@
+export default [
+  { value: '{{person.lastName}}', weight: 1 },
+  { value: '{{person.lastName}}-{{person.lastName}}', weight: 1 },
+];

src/locales/en_GH/person/name.ts

@@ -1,7 +1,3 @@
 export default [
   { value: '{{person.firstName}} {{person.lastName}}', weight: 1 },
-  {
-    value: '{{person.firstName}} {{person.lastName}}-{{person.lastName}}',
-    weight: 1,
-  },
 ];

src/locales/es/person/index.ts

@@ -7,6 +7,7 @@ import female_first_name from './female_first_name';
 import female_prefix from './female_prefix';
 import first_name from './first_name';
 import last_name from './last_name';
+import last_name_patterns from './last_name_patterns';
 import male_first_name from './male_first_name';
 import male_prefix from './male_prefix';
 import name_ from './name';
@@ -19,6 +20,7 @@ const person: PersonDefinitions = {
   female_prefix,
   first_name,
   last_name,
+  last_name_patterns,
   male_first_name,
   male_prefix,
   name: name_,

src/locales/es/person/last_name_patterns.ts

@@ -0,0 +1,6 @@
+export default [
+  {
+    value: '{{person.lastName}} {{person.lastName}}',
+    weight: 1,
+  },
+];

src/locales/es/person/name.ts

@@ -1,11 +1,10 @@
 export default [
   {
-    value:
-      '{{person.prefix}} {{person.firstName}} {{person.lastName}} {{person.lastName}}',
+    value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
     weight: 1,
   },
   {
-    value: '{{person.firstName}} {{person.lastName}} {{person.lastName}}',
+    value: '{{person.firstName}} {{person.lastName}}',
     weight: 9,
   },
 ];

src/locales/es_MX/person/index.ts

@@ -7,6 +7,7 @@ import female_first_name from './female_first_name';
 import female_prefix from './female_prefix';
 import first_name from './first_name';
 import last_name from './last_name';
+import last_name_patterns from './last_name_patterns';
 import male_first_name from './male_first_name';
 import male_prefix from './male_prefix';
 import name_ from './name';
@@ -19,6 +20,7 @@ const person: PersonDefinitions = {
   female_prefix,
   first_name,
   last_name,
+  last_name_patterns,
   male_first_name,
   male_prefix,
   name: name_,

src/locales/es_MX/person/last_name_patterns.ts

@@ -0,0 +1,10 @@
+export default [
+  {
+    value: '{{person.lastName}} {{person.lastName}}',
+    weight: 5,
+  },
+  {
+    value: '{{person.lastName}} de {{person.lastName}}',
+    weight: 1,
+  },
+];

src/locales/es_MX/person/name.ts

@@ -1,20 +1,14 @@
 export default [
   {
-    value:
-      '{{person.prefix}} {{person.firstName}} {{person.lastName}} {{person.lastName}}',
+    value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
     weight: 1,
   },
   {
-    value: '{{person.firstName}} {{person.lastName}} de {{person.lastName}}',
-    weight: 3,
+    value: '{{person.firstName}} {{person.lastName}}',
+    weight: 8,
   },
   {
-    value:
-      '{{person.suffix}} {{person.firstName}} {{person.lastName}} {{person.lastName}}',
+    value: '{{person.firstName}} {{person.lastName}} {{person.suffix}}',
     weight: 1,
   },
-  {
-    value: '{{person.firstName}} {{person.lastName}} {{person.lastName}}',
-    weight: 5,
-  },
 ];

src/locales/lv/person/index.ts

@@ -7,6 +7,7 @@ import female_first_name from './female_first_name';
 import female_last_name from './female_last_name';
 import female_prefix from './female_prefix';
 import first_name from './first_name';
+import last_name_patterns from './last_name_patterns';
 import male_first_name from './male_first_name';
 import male_last_name from './male_last_name';
 import male_prefix from './male_prefix';
@@ -20,6 +21,7 @@ const person: PersonDefinitions = {
   female_last_name,
   female_prefix,
   first_name,
+  last_name_patterns,
   male_first_name,
   male_last_name,
   male_prefix,

src/locales/lv/person/last_name_patterns.ts

@@ -0,0 +1,4 @@
+export default [
+  { value: '{{person.lastName}}', weight: 8 },
+  { value: '{{person.lastName}}-{{person.lastName}}', weight: 2 },
+];

src/locales/lv/person/name.ts

@@ -8,13 +8,4 @@ export default [
     weight: 1,
   },
   { value: '{{person.firstName}} {{person.lastName}}', weight: 7 },
-  { value: '{{person.lastName}} {{person.firstName}}', weight: 2 },
-  {
-    value: '{{person.firstName}} {{person.firstName}} {{person.lastName}}',
-    weight: 2,
-  },
-  {
-    value: '{{person.firstName}} {{person.lastName}}-{{person.lastName}}',
-    weight: 2,
-  },
 ];

src/locales/nb_NO/person/index.ts

@@ -7,6 +7,7 @@ import female_first_name from './female_first_name';
 import female_prefix from './female_prefix';
 import first_name from './first_name';
 import last_name from './last_name';
+import last_name_patterns from './last_name_patterns';
 import male_first_name from './male_first_name';
 import male_prefix from './male_prefix';
 import name_ from './name';
@@ -18,6 +19,7 @@ const person: PersonDefinitions = {
   female_prefix,
   first_name,
   last_name,
+  last_name_patterns,
   male_first_name,
   male_prefix,
   name: name_,

src/locales/nb_NO/person/last_name_patterns.ts

@@ -0,0 +1,4 @@
+export default [
+  { value: '{{person.lastName}}', weight: 8 },
+  { value: '{{person.lastName}} {{person.lastName}}', weight: 2 },
+];

src/locales/nb_NO/person/name.ts

@@ -7,13 +7,5 @@ export default [
     value: '{{person.firstName}} {{person.lastName}} {{person.suffix}}',
     weight: 1,
   },
-  {
-    value: '{{person.firstName}} {{person.firstName}} {{person.lastName}}',
-    weight: 1,
-  },
-  {
-    value: '{{person.firstName}} {{person.lastName}} {{person.lastName}}',
-    weight: 1,
-  },
-  { value: '{{person.firstName}} {{person.lastName}}', weight: 8 },
+  { value: '{{person.firstName}} {{person.lastName}}', weight: 9 },
 ];

src/locales/sv/person/index.ts

@@ -7,6 +7,7 @@ import female_first_name from './female_first_name';
 import female_prefix from './female_prefix';
 import first_name from './first_name';
 import last_name from './last_name';
+import last_name_patterns from './last_name_patterns';
 import male_first_name from './male_first_name';
 import male_prefix from './male_prefix';
 import name_ from './name';
@@ -18,6 +19,7 @@ const person: PersonDefinitions = {
   female_prefix,
   first_name,
   last_name,
+  last_name_patterns,
   male_first_name,
   male_prefix,
   name: name_,

src/locales/sv/person/last_name_patterns.ts

@@ -0,0 +1,4 @@
+export default [
+  { value: '{{person.lastName}}', weight: 8 },
+  { value: '{{person.lastName}} {{person.lastName}}', weight: 2 },
+];

src/locales/sv/person/name.ts

@@ -7,9 +7,5 @@ export default [
     value: '{{person.firstName}} {{person.lastName}} {{person.suffix}}',
     weight: 1,
   },
-  { value: '{{person.firstName}} {{person.lastName}}', weight: 8 },
-  {
-    value: '{{person.firstName}} {{person.lastName}} {{person.lastName}}',
-    weight: 1,
-  },
+  { value: '{{person.firstName}} {{person.lastName}}', weight: 9 },
 ];

src/modules/person/index.ts

@@ -111,11 +111,22 @@ export class PersonModule {
     const { last_name, female_last_name, male_last_name } =
       this.faker.definitions.person;
 
-    return selectDefinition(this.faker, sex, {
-      generic: last_name,
-      female: female_last_name,
-      male: male_last_name,
-    });
+    const makeLastName = () =>
+      selectDefinition(this.faker, sex, {
+        generic: last_name,
+        female: female_last_name,
+        male: male_last_name,
+      });
+    if (this.faker.definitions.person.last_name_patterns) {
+      const pattern = this.faker.helpers.weightedArrayElement(
+        this.faker.definitions.person.last_name_patterns
+      );
+      return this.faker.helpers.mustache(pattern, {
+        'person.lastName': makeLastName,
+      });
+    } else {
+      return makeLastName();
+    }
   }
 
   /**