-
-
Notifications
You must be signed in to change notification settings - Fork 973
fix(person): avoid repeated last name via new last_name_patterns #1819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ST-DDT
merged 10 commits into
faker-js:next
from
matthewmayer:fix/person-last-name-patterns
Feb 21, 2023
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dfb0ce7
fix(person): avoid repeated double last name via new last_name_patterns
matthewmayer 5a1cfc5
switch to use faker.helpers.fake
matthewmayer 1104a7c
Update src/modules/person/index.ts
b7e9cff
Merge branch 'next' into fix/person-last-name-patterns
b7bf81b
make selectDefinition function generic
matthewmayer 61f4d4c
add fe/male_last_name_patterns to person definitions
matthewmayer 965b621
also add hyphenated surnames for en_GB
matthewmayer d782383
lint
matthewmayer 4320bd2
Merge branch 'next' into fix/person-last-name-patterns
ST-DDT d96e16f
Merge branch 'next' into fix/person-last-name-patterns
ST-DDT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
/* | ||
* This file is automatically generated. | ||
* Run 'pnpm run generate:locales' to update. | ||
*/ | ||
import type { PersonDefinitions } from '../../..'; | ||
import last_name_patterns from './last_name_patterns'; | ||
import name_ from './name'; | ||
|
||
const person: PersonDefinitions = { | ||
last_name_patterns, | ||
name: name_, | ||
}; | ||
|
||
export default person; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export default [ | ||
{ value: '{{person.last_name}}', weight: 9 }, | ||
{ value: '{{person.last_name}}-{{person.last_name}}', weight: 1 }, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export default [ | ||
{ value: '{{person.firstName}} {{person.lastName}}', weight: 7 }, | ||
{ | ||
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}', | ||
weight: 1, | ||
}, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export default [ | ||
{ value: '{{person.last_name}}', weight: 1 }, | ||
{ value: '{{person.last_name}}-{{person.last_name}}', weight: 1 }, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
export default [ | ||
{ value: '{{person.firstName}} {{person.lastName}}', weight: 1 }, | ||
{ | ||
value: '{{person.firstName}} {{person.lastName}}-{{person.lastName}}', | ||
weight: 1, | ||
}, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
export default [ | ||
{ | ||
value: '{{person.last_name}} {{person.last_name}}', | ||
weight: 1, | ||
}, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,10 @@ | ||
export default [ | ||
{ | ||
value: | ||
'{{person.prefix}} {{person.firstName}} {{person.lastName}} {{person.lastName}}', | ||
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}', | ||
weight: 1, | ||
}, | ||
{ | ||
value: '{{person.firstName}} {{person.lastName}} {{person.lastName}}', | ||
value: '{{person.firstName}} {{person.lastName}}', | ||
weight: 9, | ||
}, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
export default [ | ||
{ | ||
value: '{{person.last_name}} {{person.last_name}}', | ||
weight: 5, | ||
}, | ||
{ | ||
value: '{{person.last_name}} de {{person.last_name}}', | ||
weight: 1, | ||
}, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,14 @@ | ||
export default [ | ||
{ | ||
value: | ||
'{{person.prefix}} {{person.firstName}} {{person.lastName}} {{person.lastName}}', | ||
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}', | ||
weight: 1, | ||
}, | ||
{ | ||
value: '{{person.firstName}} {{person.lastName}} de {{person.lastName}}', | ||
weight: 3, | ||
value: '{{person.firstName}} {{person.lastName}}', | ||
weight: 8, | ||
}, | ||
{ | ||
value: | ||
'{{person.suffix}} {{person.firstName}} {{person.lastName}} {{person.lastName}}', | ||
value: '{{person.firstName}} {{person.lastName}} {{person.suffix}}', | ||
weight: 1, | ||
}, | ||
{ | ||
value: '{{person.firstName}} {{person.lastName}} {{person.lastName}}', | ||
weight: 5, | ||
}, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export default [ | ||
{ value: '{{person.female_last_name}}', weight: 8 }, | ||
{ | ||
value: '{{person.female_last_name}}-{{person.female_last_name}}', | ||
weight: 2, | ||
}, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export default [ | ||
{ value: '{{person.male_last_name}}', weight: 8 }, | ||
{ value: '{{person.male_last_name}}-{{person.male_last_name}}', weight: 2 }, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export default [ | ||
{ value: '{{person.last_name}}', weight: 8 }, | ||
{ value: '{{person.last_name}} {{person.last_name}}', weight: 2 }, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export default [ | ||
{ value: '{{person.last_name}}', weight: 8 }, | ||
{ value: '{{person.last_name}} {{person.last_name}}', weight: 2 }, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.