Skip to content

docs: add matthewmayer to team #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2023
Merged

docs: add matthewmayer to team #1816

merged 2 commits into from
Feb 11, 2023

Conversation

Shinigami92
Copy link
Member

Add @matthewmayer to team page

@Shinigami92 Shinigami92 added the c: docs Improvements or additions to documentation label Feb 8, 2023
@Shinigami92 Shinigami92 self-assigned this Feb 8, 2023
@Shinigami92 Shinigami92 requested a review from a team February 8, 2023 12:20
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 8, 2023 12:20
@codecov
Copy link

codecov bot commented Feb 8, 2023 •
edited
Loading

Codecov Report

Merging #1816 (8969e08) into next (a51521d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1816      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2347     2347              
  Lines      235657   235657              
  Branches     1139     1140       +1     
==========================================
- Hits       234786   234785       -1     
- Misses        849      850       +1     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/location/index.ts 98.70% <0.00%> (-0.22%) ⬇️
src/modules/internet/user-agent.ts 89.34% <0.00%> (+0.29%) ⬆️

ST-DDT
ST-DDT approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I didnt add this myself because of the blanks you and I cannot fill.

matthewmayer
matthewmayer approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me. I don't have any social media to promote so can leave blank.

@ST-DDT ST-DDT enabled auto-merge (squash) February 11, 2023 11:13
@ST-DDT ST-DDT merged commit d5b78c7 into next Feb 11, 2023
@ST-DDT ST-DDT deleted the add-matthewmayer-to-team branch February 11, 2023 11:54
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
@Shinigami92 @matthewmayer
docs: add matthewmayer to team (faker-js#1816)
db3e6b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: docs Improvements or additions to documentation
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @matthewmayer @ST-DDT