chore: fix missing defaultRefDate calls #1781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1781 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 2340 2340
Lines 242669 242654 -15
Branches 1112 1109 -3
==========================================
- Hits 241819 241802 -17
- Misses 829 831 +2
Partials 21 21
|
xDivisionByZerox
approved these changes
Jan 25, 2023
Shinigami92
approved these changes
Jan 25, 2023
|
Why wasn't this catched by a test? |
|
Because it defaulted to new Date. Thats the reason, why I removed the default from the toDate method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like I missed some
toDatecalls in #1757(Found via
docs:diff(#1755))