-
-
Notifications
You must be signed in to change notification settings - Fork 973
docs: show source link #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: show source link #1780
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1780 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 2346 2346
Lines 235115 235115
Branches 1135 1132 -3
==========================================
- Hits 234263 234258 -5
- Misses 830 835 +5
Partials 22 22
|
I think its a bit too prominent. Most people reading the docs won't use it. I'd make it light gray so its less prominent than the method name and description. |
We could also add a small github icon with a tooltip 🤔 |
Why does it keep removing the request for review from @matthewmayer ? |
e8df892
@ST-DDT if you consider @matthewmayer's review already as member review, then I accept if you already merge right now 🙂 @matthewmayer team membership does not mean you need to attempt at meetings but provides you the ability for green approvals (and other stuff)
|
Sure, you can add me on the team if that makes it easier to request reviews etc. Since my Typescript is fairly limited I'll only approve PRs which are more locale-focused or documentation-focused like this one. |
Co-authored-by: Shinigami92 <[email protected]>
Fixes #1695
This PR ads a
Goto Source
link to each method.The source link targets the first line of the last api signature (not the impl signature).
E.g.
https://github.com/faker-js/faker/blob/d16a4d2d/src/modules/date/index.ts#L105
I haven't found a good way to display it yet.
If we don't find something better, we can just start with this and change the appearance later.
Things to decide:
Things to keep in mind:
sourceLink
from the diff as both the commitId/branchName and the line number are likely to create lots of false positives.