-
-
Notifications
You must be signed in to change notification settings - Fork 974
docs(date): clarify the purpose of the context parameter #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ST-DDT
merged 11 commits into
faker-js:next
from
matthewmayer:chore/clarify-context-parameter-for-month-and-weekday
Nov 25, 2022
Merged
docs(date): clarify the purpose of the context parameter #1576
ST-DDT
merged 11 commits into
faker-js:next
from
matthewmayer:chore/clarify-context-parameter-for-month-and-weekday
Nov 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1576 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2220 2220
Lines 238957 238957
Branches 1035 1035
=======================================
Hits 238095 238095
Misses 841 841
Partials 21 21
|
ejcheng
reviewed
Nov 20, 2022
Co-authored-by: Eric Cheng <[email protected]>
Co-authored-by: Eric Cheng <[email protected]>
Shinigami92
reviewed
Nov 21, 2022
Co-authored-by: Shinigami <[email protected]>
Shinigami92
previously approved these changes
Nov 22, 2022
ST-DDT
reviewed
Nov 22, 2022
ST-DDT
previously approved these changes
Nov 23, 2022
ejcheng
previously approved these changes
Nov 23, 2022
Shinigami92
reviewed
Nov 23, 2022
Co-authored-by: Shinigami <[email protected]>
Shinigami92
approved these changes
Nov 24, 2022
ST-DDT
approved these changes
Nov 24, 2022
ejcheng
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: docs
Improvements or additions to documentation
m: date
Something is referring to the date module
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better document the
context
parameter offaker.date.weekday()
andfaker.date.month()
since its not used in English.