Skip to content

chore(docs): fix imports #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2022
Merged

chore(docs): fix imports #154

merged 2 commits into from
Jan 17, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jan 15, 2022

I found some old import statements and replaced them in the docs

@Shinigami92 Shinigami92 added c: docs Improvements or additions to documentation c: chore PR that doesn't affect the runtime behavior labels Jan 15, 2022
@Shinigami92 Shinigami92 requested review from JessicaSachs and a team January 15, 2022 13:59
@Shinigami92 Shinigami92 self-assigned this Jan 15, 2022
@netlify
Copy link

netlify bot commented Jan 15, 2022

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 1568977

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e32cd45deb180008ca9079

😎 Browse the preview: https://deploy-preview-154--vigilant-wescoff-04e480.netlify.app

Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Shinigami92
Copy link
Member Author

You already deleted the doc folder
This is not visible in the current PR, so please change the GitHub option to

image

@Shinigami92 Shinigami92 requested a review from a team January 15, 2022 20:22
@prisis prisis added this to the v6.0.0 milestone Jan 16, 2022
@damienwebdev damienwebdev merged commit a973ee1 into main Jan 17, 2022
@damienwebdev damienwebdev deleted the docs-fix-imports branch January 17, 2022 15:43
renbaoshuo added a commit to renbaoshuo/faker that referenced this pull request Jan 18, 2022
Shinigami92 added a commit to MohdImran001/faker that referenced this pull request Jan 18, 2022
pkuczynski pushed a commit to pkuczynski/faker that referenced this pull request Jan 21, 2022
renbaoshuo added a commit to renbaoshuo/faker that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants