Skip to content

docs: update since tags for person and location #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2022
Merged

docs: update since tags for person and location #1516

merged 3 commits into from
Nov 6, 2022

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Nov 4, 2022 •
edited
Loading

fix #1479

@matthewmayer matthewmayer marked this pull request as ready for review November 4, 2022 01:30
@matthewmayer matthewmayer requested a review from a team as a code owner November 4, 2022 01:30
@codecov
Copy link

codecov bot commented Nov 4, 2022 •
edited
Loading

Codecov Report

Merging #1516 (c1fb6f1) into next (0b9989f) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1516   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2213     2213           
  Lines      238633   238633           
  Branches     1014     1014           
=======================================
  Hits       237779   237779           
  Misses        833      833           
  Partials       21       21
Impacted Files Coverage Δ
src/modules/location/index.ts 99.78% <100.00%> (ø)
src/modules/person/index.ts 100.00% <100.00%> (ø)

@ejcheng ejcheng added c: docs Improvements or additions to documentation m: location Something is referring to the location module labels Nov 4, 2022
@ejcheng ejcheng added this to the v8.0 - Module Re-Shuffling milestone Nov 4, 2022
@ejcheng ejcheng requested a review from a team November 4, 2022 04:29
@ejcheng ejcheng added the m: person Something is referring to the person module label Nov 4, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Nov 4, 2022
@ST-DDT ST-DDT requested review from a team November 4, 2022 07:27
@ST-DDT ST-DDT enabled auto-merge (squash) November 6, 2022 15:03
@ST-DDT ST-DDT merged commit 1bed403 into faker-js:next Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ejcheng ejcheng ejcheng approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: docs Improvements or additions to documentation m: location Something is referring to the location module m: person Something is referring to the person module s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

@since values are wrong for faker.person.*
4 participants
@matthewmayer @ST-DDT @Shinigami92 @ejcheng