Skip to content

docs(helpers): extend module jsdocs #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 10, 2022
Merged

docs(helpers): extend module jsdocs #1515

merged 6 commits into from
Nov 10, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 3, 2022

Extend the helpers module jsdocs with a hint that these methods are intended to be used to build other faker methods.
Not sure about the exact wording.

As decided here: #1486 (comment)

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: helpers Something is referring to the helpers module labels Nov 3, 2022
@ST-DDT ST-DDT requested review from a team November 3, 2022 22:34
@ST-DDT ST-DDT self-assigned this Nov 3, 2022
@ST-DDT ST-DDT changed the title docs: extend helpers module jsdocs docs(helpers): extend helpers module jsdocs Nov 3, 2022
@ST-DDT ST-DDT changed the title docs(helpers): extend helpers module jsdocs docs(helpers): extend module jsdocs Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #1515 (fe2c3e8) into next (3777c44) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1515   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2214     2214           
  Lines      238813   238812    -1     
  Branches     1029     1029           
=======================================
- Hits       237951   237950    -1     
  Misses        841      841           
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/helpers/index.ts 98.51% <100.00%> (-0.01%) ⬇️

Co-authored-by: Eric Cheng <[email protected]>
@ST-DDT ST-DDT requested review from a team November 8, 2022 20:33
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team November 9, 2022 21:17
@ST-DDT ST-DDT enabled auto-merge (squash) November 10, 2022 09:01
@ST-DDT ST-DDT merged commit ded5df3 into next Nov 10, 2022
@ST-DDT ST-DDT deleted the jsdocs/helpers-module branch November 10, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: docs Improvements or additions to documentation m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants