docs: list required JSDoc tags #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: docs
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1397 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2163 2163
Lines 241306 241306
Branches 1017 1017
=======================================
Hits 240399 240399
Misses 886 886
Partials 21 21 |
Closed
xDivisionByZerox
previously approved these changes
Sep 26, 2022
Shinigami92
reviewed
Sep 26, 2022
ejcheng
reviewed
Sep 27, 2022
Co-authored-by: Eric Cheng <[email protected]>
ejcheng
approved these changes
Sep 27, 2022
Shinigami92
approved these changes
Sep 29, 2022
Shinigami92
changed the title
wael-fadlallah
pushed a commit
to wael-fadlallah/faker
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the contribution guide with a section which jsdoc tags should be added to new methods.