-
-
Notifications
You must be signed in to change notification settings - Fork 974
docs: localization #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
docs: localization #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1364 +/- ##
==========================================
- Coverage 99.62% 99.62% -0.01%
==========================================
Files 2163 2163
Lines 241264 241264
Branches 1015 1014 -1
==========================================
- Hits 240364 240357 -7
- Misses 879 886 +7
Partials 21 21
|
ST-DDT
reviewed
Sep 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a newline after each sentence to avoid 200+char long lines.
Please also make sure that you refer to Faker
consistently (vs faker
).
Languages are always capitalized.
ST-DDT
requested changes
Sep 10, 2022
Co-authored-by: ST-DDT <[email protected]>
xDivisionByZerox
previously approved these changes
Sep 10, 2022
ejcheng
reviewed
Sep 10, 2022
Co-authored-by: Eric Cheng <[email protected]>
ST-DDT
previously approved these changes
Sep 10, 2022
ejcheng
previously approved these changes
Sep 10, 2022
xDivisionByZerox
previously approved these changes
Sep 10, 2022
1391356
ST-DDT
approved these changes
Sep 11, 2022
ejcheng
approved these changes
Sep 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1322
Co-authored-by: Leyla Jähnig [email protected]
Co-authored-by: ST-DDT [email protected]