test: remove JSON.stringify wrapper around faker.seed() in tests descriptions

[pkuczynski]

I am not sure why we had those JSON.stringify @Shinigami92?

[codecov]

Codecov Report

Merging #1196 (006a548) into main (6629806) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 006a548 differs from pull request most recent head 51e29fe. Consider uploading reports for the commit 51e29fe to get more accurate results

@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
+ Coverage   99.63%   99.64%   +0.01%     
==========================================
  Files        2148     2146       -2     
  Lines      230582   230499      -83     
  Branches      983      981       -2     
==========================================
- Hits       229736   229689      -47     
+ Misses        825      789      -36     
  Partials       21       21              

Impacted Files	Coverage Δ
src/modules/internet/user-agent.ts	87.24% <0.00%> (-5.51%)	⬇️
src/definitions/date.ts	0.00% <0.00%> (ø)
src/definitions/color.ts	0.00% <0.00%> (ø)
src/definitions/hacker.ts	0.00% <0.00%> (ø)
src/definitions/system.ts	0.00% <0.00%> (ø)
src/definitions/address.ts	0.00% <0.00%> (ø)
src/definitions/company.ts	0.00% <0.00%> (ø)
src/definitions/finance.ts	0.00% <0.00%> (ø)
src/definitions/science.ts	0.00% <0.00%> (ø)
src/definitions/vehicle.ts	0.00% <0.00%> (ø)
... and 7 more

[xDivisionByZerox]

They were wrapped due to faker.seed being able to return an array of numbers if one is used as input value. But we don't do that so this should be fine.

[ST-DDT]

I think it's okay.

[pkuczynski]

They were wrapped due to faker.seed being able to return an array of numbers if one is used as input value. But we don't do that so this should be fine.

1. seed(seed?: number): number;
2. console.log(`${[1, 2, 3]}`) // '1,2,3'

:)

[xDivisionByZerox]

console.log(${[1, 2, 3]}) // '1,2,3'

And that's why JSON.stringif was used for arrays. Because this output this sh*t. I mean it works but doesn't provide clarity. You could also have written console.log(`${seed1}, ${seed2}, ${seed3}`).
One the other side, JSON gives me a nicely formatted array console.log(JSON.stringify([1,2,3])) // [1,2,3].

But it doesn't matter since we know now from the signature overload if the return value will be an array or not and can act accordingly.

[pkuczynski]

From the signature we know it's never an array :)

[xDivisionByZerox]

faker/src/faker.ts

Lines 242 to 244 in 5ea8252

	seed(
	seed: number | number[] = Math.ceil(Math.random() * Number.MAX_SAFE_INTEGER)
	): number | number[] {

It literally has number OR number[] as return type.

[pkuczynski]

Indeed! I haven't notice the overload because of jsdoc, sorry :)