Skip to content

chore(linter): set 'jsdoc/sort-tags' rule to 'error' #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

xDivisionByZerox
Copy link
Member

Since we have no warnings for the jsdoc/sort-tags eslint rule anymore I promoted its mode from 'warning' to 'error' as stated in the comment above.

@xDivisionByZerox xDivisionByZerox added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Jul 20, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Jul 20, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team July 20, 2022 16:10
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner July 20, 2022 16:10
@xDivisionByZerox xDivisionByZerox self-assigned this Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@b0a4847). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1173   +/-   ##
=======================================
  Coverage        ?   99.64%           
=======================================
  Files           ?     2146           
  Lines           ?   230467           
  Branches        ?      980           
=======================================
  Hits            ?   229657           
  Misses          ?      789           
  Partials        ?       21           

@ST-DDT ST-DDT requested review from a team July 21, 2022 04:05
@Shinigami92 Shinigami92 merged commit fbddaa3 into main Jul 21, 2022
@ST-DDT ST-DDT deleted the chore/linter/stricten-jsdoc-sort-tags branch July 21, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants