Skip to content

docs(definitions): minor formatting to definitions' types #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2022
Merged

docs(definitions): minor formatting to definitions' types #1172

merged 4 commits into from
Jul 27, 2022

Conversation

hankucz
Copy link
Contributor

@hankucz hankucz commented Jul 20, 2022

Align definitions documentation...

@hankucz hankucz requested a review from a team as a code owner July 20, 2022 11:33
@codecov
Copy link

codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #1172 (1cc1f4a) into main (22a050e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 1cc1f4a differs from pull request most recent head 1bc61dc. Consider uploading reports for the commit 1bc61dc to get more accurate results

@@            Coverage Diff             @@
##             main    #1172      +/-   ##
==========================================
- Coverage   99.64%   99.63%   -0.02%     
==========================================
  Files        2148     2146       -2     
  Lines      230530   230551      +21     
  Branches      980      984       +4     
==========================================
- Hits       229717   229698      -19     
- Misses        792      832      +40     
  Partials       21       21
Impacted Files Coverage Δ
src/definitions/address.ts 0.00% <0.00%> (ø)
src/definitions/color.ts 0.00% <0.00%> (ø)
src/definitions/commerce.ts 0.00% <0.00%> (ø)
src/definitions/company.ts 0.00% <0.00%> (ø)
src/definitions/database.ts 0.00% <0.00%> (ø)
src/definitions/date.ts 0.00% <0.00%> (ø)
src/definitions/finance.ts 0.00% <0.00%> (ø)
src/definitions/hacker.ts 0.00% <0.00%> (ø)
src/definitions/internet.ts 0.00% <0.00%> (ø)
src/definitions/name.ts 0.00% <0.00%> (ø)
... and 7 more

@ejcheng ejcheng added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Jul 20, 2022
@ejcheng ejcheng added this to the v7 - Current Major milestone Jul 20, 2022
ST-DDT
ST-DDT reviewed Jul 21, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Jul 21, 2022
@hankucz hankucz requested a review from ST-DDT July 26, 2022 18:14
@ST-DDT ST-DDT requested review from a team July 26, 2022 21:52
xDivisionByZerox
xDivisionByZerox approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is big for consistency!

@ST-DDT ST-DDT requested a review from a team July 27, 2022 00:19
@ST-DDT ST-DDT enabled auto-merge (squash) July 27, 2022 00:19
@ST-DDT ST-DDT merged commit e007abb into faker-js:main Jul 27, 2022
@hankucz hankucz deleted the jsdoc-definitions branch August 3, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkuczynski pkuczynski pkuczynski approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@hankucz hankucz

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
5 participants
@hankucz @pkuczynski @ST-DDT @xDivisionByZerox @ejcheng