-
-
Notifications
You must be signed in to change notification settings - Fork 974
chore(linting): add naming convention rule #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1170 +/- ##
==========================================
- Coverage 99.65% 99.64% -0.01%
==========================================
Files 2146 2146
Lines 230462 230467 +5
Branches 983 980 -3
==========================================
- Hits 229671 229657 -14
- Misses 770 789 +19
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with that for now
But is there maybe a no-config default-preset?
Not that I'm aware of. All configs we extend from do not set this rule. TBH, I'm a big fan of explicitly settings configs and not relying on defaults. That way you ensure your config always stays the same even if the preset you extend from decides to change their settings. But that's my opinion. |
I second that. |
This reverts commit b0a4847.
Add a basic linting rule to apply naming conventions.
For now, I only added the rule that classes, interfaces, type declarations, and enum members have to be written in
PascalCase
.I'm open to more strict definitions in this PR.