Skip to content

chore: cleanup gender list for en locale #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2022
Merged

chore: cleanup gender list for en locale #1146

merged 3 commits into from
Jul 12, 2022

Conversation

hankucz
Copy link
Contributor

@hankucz hankucz commented Jul 12, 2022 •
edited
Loading

  • synchronize with wikipedia
  • remove entries not fitting into this category (eg. asexual)
  • sort alphabetically

@hankucz hankucz requested a review from a team as a code owner July 12, 2022 14:10
@xDivisionByZerox
Copy link
Member

LGTM :)
Thanks for your contribution.

@xDivisionByZerox xDivisionByZerox added the c: locale Permutes locale definitions label Jul 12, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Jul 12, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team July 12, 2022 14:24
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1146 (4f56ae7) into main (5443b56) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files        2146     2146              
  Lines      230395   230401       +6     
  Branches      980      978       -2     
==========================================
  Hits       229588   229588              
- Misses        786      792       +6     
  Partials       21       21
Impacted Files Coverage Δ
src/locales/en/name/gender.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 86.37% <0.00%> (-0.87%) ⬇️
src/modules/finance/index.ts 99.31% <0.00%> (-0.69%) ⬇️

@Shinigami92 Shinigami92 merged commit 3c108b4 into faker-js:main Jul 12, 2022
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@hankucz @Minozzzi
chore: cleanup gender list for en locale (faker-js#1146)
46d8305
@hankucz hankucz deleted the gender-list-update branch July 19, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisis prisis prisis approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@hankucz hankucz

Labels
c: locale Permutes locale definitions
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
4 participants
@hankucz @xDivisionByZerox @prisis @Shinigami92