Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android build fail due to CREDENTIALS_API #109

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

WooWan
Copy link
Contributor

@WooWan WooWan commented Feb 16, 2024

Fixes build error
Build was failed, and i got following error:

`Note: Recompile with -Xlint:deprecation for details.
/Users/steavenbc/Documents/codes/ws-mobile/ws-mobile/node_modules/react-native-otp-verify/android/src/main/java/com/faizal/OtpVerify/OtpVerifyModule.java:54: error: cannot find symbol
.addApi(Auth.CREDENTIALS_API)
^
symbol: variable CREDENTIALS_API
location: class Auth
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':react-native-otp-verify:compileReleaseJavaWithJavac'.

fixes: #108

Copy link

@KManiKumarReddy KManiKumarReddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEED THIS FIX URGENTLY

@faizalshap
Copy link
Owner

I am on it

Copy link

@royalbhati royalbhati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubhamdehaat
Copy link

@faizalshap - Any way to make this work in older versions? Since the older version of my app has a good installation base.

@faizalshap
Copy link
Owner

Which version?

Copy link

@CodeWithMufaddal CodeWithMufaddal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIx this asap

CodeWithMufaddal

This comment was marked as duplicate.

@shubhamdehaat
Copy link

Which version?

1.1.4 but I think that version is working fine. Please fix issue in 1.1.6

Copy link

@Saliheen Saliheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working

@Piyush023
Copy link

Please Fix this issue asap

rttss-sahil

This comment was marked as duplicate.

@IndrakumarR
Copy link

Working

how ?

@i-am-dev-Siddhesh
Copy link

\node_modules\react-native-otp-verify\android\src\main\java\com\faizal\OtpVerify\OtpVerifyModule.java:54: error: cannot find symbol
.addApi(Auth.CREDENTIALS_API)

got above error. Please update as soon as possible

@dravecky
Copy link

@faizalshap please approve and merge asap

@faizalshap
Copy link
Owner

Ok

@faizalshap faizalshap merged commit 2bc0211 into faizalshap:master Feb 16, 2024
@samcasmmm
Copy link

having same issue with 1.1.4

@KManiKumarReddy
Copy link

having same issue with 1.1.4

there's no way it will automatically work for previous versions, if you need to definitely use old versions you need to either patch it or if possible set playServicesVersion or googlePlayServicesVersion in your build.gradle. Refer to this comment for more details: #108 (comment)

@samcasmmm
Copy link

updated to 1.1.6. now working. thanks for reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error since Feb 16, 2024