Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

Organize hooks better in a dedicated HOOKS key in the config #174

Closed
wants to merge 5 commits into from

Conversation

prigoyal
Copy link
Contributor

@prigoyal prigoyal commented Feb 8, 2021

Summary:
vissl has many hooks that can be configured. but they were scattered all over the defaults.yaml unclear what parameter is a hook.

reorganizing them under HOOKS for better readibility

Differential Revision: D26284129

Differential Revision: D26236748

fbshipit-source-id: 15b8bbf2ea3fb8f31ffbb65bb0382ceb1c11b7fe
Differential Revision: D26276800

fbshipit-source-id: 407cbf415cda9416854dd3615408ea5bedf2dd41
Differential Revision: D26276803

fbshipit-source-id: 3f45c4173339ba222358714009a95c957528c269
Differential Revision: D26284304

fbshipit-source-id: 278c18689edd0c4262cfff0e58b4c9b720d1dac4
Summary:
vissl has many hooks that can be configured. but they were scattered all over the defaults.yaml unclear what parameter is a hook.

reorganizing them under `HOOKS` for better readibility

Differential Revision: D26284129

fbshipit-source-id: dab1505d3c411d46a90daaf6916213b510221d4a
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Feb 8, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26284129

facebook-github-bot pushed a commit that referenced this pull request Feb 9, 2021
Summary:
Pull Request resolved: #174

vissl has many hooks that can be configured. but they were scattered all over the defaults.yaml unclear what parameter is a hook.

reorganizing them under `HOOKS` for better readibility

Reviewed By: min-xu-ai

Differential Revision: D26284129

fbshipit-source-id: c71a69bb838cdb76d3e0594efddf584a5b3f8b68
facebook-github-bot pushed a commit that referenced this pull request Jul 28, 2021
Summary:
This PR introduces a script to automatically download kinetics 700 and format it in `disk_folder` and `disk_filelist` format.

Pull Request resolved: fairinternal/ssl_scaling#174

Reviewed By: prigoyal

Differential Revision: D29917908

Pulled By: QuentinDuval

fbshipit-source-id: 66d244bfc6ed219ae12ad333705c9687ee08b47a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants