[new-hs-indexer #5] tag refs with import/export/code #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fb-oss-glean canceled.
|
facebook-github-bot
added
the
CLA Signed
simonmar
force-pushed
the
import-export-refs
branch
from
71f79fd to
c30c4fa
Compare
|
@iamirzhan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
simonmar
force-pushed
the
import-export-refs
branch
from
c30c4fa to
487e533
Compare
simonmar
changed the title
simonmar
force-pushed
the
import-export-refs
branch
from
487e533 to
78262d3
Compare
It's useful to be able to know whether a ref is in an import or export, e.g. for dead code detection, so let's tag refs with an enum to say what kind of ref it is. I changed field names so that the schema change shouldn't trigger a validation failure (I hope).
simonmar
force-pushed
the
import-export-refs
branch
from
78262d3 to
0dbb4cb
Compare
|
@bochko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
Summary: 1. Ignore Names that come from another source file (TODO) 2. Ignore Names that come from the current source file but have a line number outside the valid range. No idea why this happens, I didn't investigate. Note: stacked on #518 Pull Request resolved: #521 Reviewed By: donsbot Differential Revision: D75289445 Pulled By: bochko fbshipit-source-id: 212e6c2e4432ef3840d75e8fa187033a15e58e04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to be able to know whether a ref is in an import or export,
e.g. for dead code detection, so let's tag refs with an enum to say what
kind of ref it is.
I changed field names so that the schema change shouldn't trigger a
validation failure (I hope).
Note: stacked on #511