Skip to content

Unnecessary cheks for __DEV__ #33722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unnecessary cheks for __DEV__ #33722

wants to merge 1 commit into from

Conversation

mendlero
Copy link

@mendlero mendlero commented Jul 7, 2025

In one of the files of react package there are checks of the form: __DEV__ && ... inside of an if whose condition is that __DEV__ is true so && will always return the second operand.
This pull requests simply deltes those redundant checks

@facebook-github-bot
Copy link
Contributor

Hi @mendlero!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@kushxg kushxg mentioned this pull request Jul 7, 2025
Open
@mendlero
Copy link
Author

mendlero commented Jul 7, 2025 •
edited
Loading

I appolegize for not checking what I need to do before opening a pull request. signed the cla now

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@react-sizebot
Copy link

Comparing: 223f81d...87c367b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.50 kB 530.50 kB = 93.66 kB 93.66 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 655.04 kB 655.04 kB = 115.35 kB 115.35 kB
facebook-www/ReactDOM-prod.classic.js = 675.12 kB 675.12 kB = 118.77 kB 118.77 kB
facebook-www/ReactDOM-prod.modern.js = 665.54 kB 665.54 kB = 117.13 kB 117.13 kB
oss-experimental/react-client/cjs/react-client-flight.development.js = 153.51 kB 150.33 kB = 26.93 kB 26.43 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 117.96 kB 115.39 kB = 21.95 kB 21.51 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 117.96 kB 115.39 kB = 21.95 kB 21.51 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 117.87 kB 115.30 kB = 21.92 kB 21.48 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 117.87 kB 115.30 kB = 21.92 kB 21.48 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 114.83 kB 112.20 kB = 21.45 kB 21.00 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 114.83 kB 112.20 kB = 21.45 kB 21.00 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 112.24 kB 109.66 kB = 20.98 kB 20.50 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 112.19 kB 109.61 kB = 20.95 kB 20.47 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 111.68 kB 109.10 kB = 20.84 kB 20.36 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 111.63 kB 109.05 kB = 20.81 kB 20.34 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 119.17 kB 116.39 kB = 22.12 kB 21.63 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 119.17 kB 116.39 kB = 22.12 kB 21.63 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 109.50 kB 106.92 kB = 20.45 kB 19.97 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 109.45 kB 106.87 kB = 20.42 kB 19.95 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 110.64 kB 108.02 kB = 20.51 kB 20.02 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 110.59 kB 107.97 kB = 20.49 kB 20.00 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 151.26 kB 147.61 kB = 35.16 kB 34.18 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 151.23 kB 147.58 kB = 35.13 kB 34.15 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 116.30 kB 113.46 kB = 21.63 kB 21.13 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 116.30 kB 113.46 kB = 21.63 kB 21.13 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 113.73 kB 110.91 kB = 21.17 kB 20.68 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 113.73 kB 110.91 kB = 21.17 kB 20.68 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 123.20 kB 120.07 kB = 22.67 kB 22.11 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 123.20 kB 120.07 kB = 22.67 kB 22.11 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 121.87 kB 118.74 kB = 22.42 kB 21.86 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 121.87 kB 118.74 kB = 22.42 kB 21.86 kB
oss-stable/react-client/cjs/react-client-flight.development.js = 111.07 kB 107.99 kB = 20.12 kB 19.66 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js = 111.05 kB 107.96 kB = 20.10 kB 19.63 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js = 58.02 kB 57.90 kB = 11.60 kB 11.56 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js = 58.02 kB 57.90 kB = 11.60 kB 11.56 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js = 57.59 kB 57.47 kB = 11.51 kB 11.46 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js = 57.59 kB 57.47 kB = 11.51 kB 11.46 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js = 58.60 kB 58.47 kB = 11.70 kB 11.65 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js = 58.16 kB 58.04 kB = 11.60 kB 11.55 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 55.68 kB 55.56 kB = 11.11 kB 11.07 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 55.68 kB 55.56 kB = 11.11 kB 11.07 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js = 55.46 kB 55.34 kB = 11.02 kB 10.98 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js = 55.46 kB 55.34 kB = 11.02 kB 10.98 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 56.25 kB 56.13 kB = 11.21 kB 11.16 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js = 56.04 kB 55.91 kB = 11.12 kB 11.07 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js = 125.57 kB 125.28 kB = 22.81 kB 22.75 kB
oss-stable/react-server/cjs/react-server-flight.development.js = 125.57 kB 125.28 kB = 22.81 kB 22.75 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js = 68.65 kB 68.48 kB = 13.57 kB 13.50 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js = 67.47 kB 67.30 kB = 13.33 kB 13.26 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js = 60.88 kB 60.73 kB = 12.24 kB 12.20 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js = 60.88 kB 60.73 kB = 12.24 kB 12.20 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js = 61.46 kB 61.30 kB = 12.33 kB 12.29 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js = 68.09 kB 67.92 kB = 13.47 kB 13.40 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js = 68.09 kB 67.92 kB = 13.47 kB 13.40 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js = 64.77 kB 64.61 kB = 12.97 kB 12.92 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js = 64.77 kB 64.61 kB = 12.97 kB 12.92 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js = 65.35 kB 65.18 kB = 13.06 kB 13.01 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js = 66.92 kB 66.74 kB = 13.22 kB 13.16 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js = 66.92 kB 66.74 kB = 13.22 kB 13.16 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js = 61.60 kB 61.39 kB = 12.33 kB 12.28 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js = 61.60 kB 61.39 kB = 12.33 kB 12.28 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js = 62.17 kB 61.96 kB = 12.43 kB 12.37 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js = 640.70 kB 638.38 kB = 113.39 kB 112.92 kB
oss-experimental/react-client/cjs/react-client-flight.production.js = 63.79 kB 63.53 kB = 11.68 kB 11.63 kB
oss-stable/react-client/cjs/react-client-flight.production.js = 63.30 kB 63.04 kB = 11.60 kB 11.54 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.js = 63.28 kB 63.02 kB = 11.58 kB 11.52 kB
oss-experimental/react-server/cjs/react-server-flight.production.js = 66.22 kB 65.87 kB = 13.03 kB 12.99 kB
oss-stable-semver/react-server/cjs/react-server-flight.production.js = 60.61 kB 60.27 kB = 12.15 kB 12.10 kB
oss-stable/react-server/cjs/react-server-flight.production.js = 60.61 kB 60.27 kB = 12.15 kB 12.10 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 89.10 kB 88.51 kB = 18.50 kB 18.38 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 89.10 kB 88.51 kB = 18.50 kB 18.38 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 89.84 kB 89.24 kB = 18.62 kB 18.50 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 160.39 kB 157.72 kB = 28.86 kB 28.39 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 160.30 kB 157.63 kB = 28.83 kB 28.35 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 157.26 kB 154.54 kB = 28.35 kB 27.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 154.68 kB 152.00 kB = 27.79 kB 27.34 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 154.13 kB 151.45 kB = 27.65 kB 27.18 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 151.94 kB 149.26 kB = 27.26 kB 26.80 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 153.08 kB 150.37 kB = 27.27 kB 26.78 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 161.60 kB 158.72 kB = 28.96 kB 28.46 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 187.72 kB 184.25 kB = 41.97 kB 41.08 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 158.73 kB 155.79 kB = 28.48 kB 27.92 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 156.17 kB 153.25 kB = 28.02 kB 27.49 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 165.64 kB 162.40 kB = 29.50 kB 28.94 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 164.30 kB 161.07 kB = 29.26 kB 28.70 kB
oss-experimental/react-client/cjs/react-client-flight.development.js = 153.51 kB 150.33 kB = 26.93 kB 26.43 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 117.96 kB 115.39 kB = 21.95 kB 21.51 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 117.96 kB 115.39 kB = 21.95 kB 21.51 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 117.87 kB 115.30 kB = 21.92 kB 21.48 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 117.87 kB 115.30 kB = 21.92 kB 21.48 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 114.83 kB 112.20 kB = 21.45 kB 21.00 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 114.83 kB 112.20 kB = 21.45 kB 21.00 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 112.24 kB 109.66 kB = 20.98 kB 20.50 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 112.19 kB 109.61 kB = 20.95 kB 20.47 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 111.68 kB 109.10 kB = 20.84 kB 20.36 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 111.63 kB 109.05 kB = 20.81 kB 20.34 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 119.17 kB 116.39 kB = 22.12 kB 21.63 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 119.17 kB 116.39 kB = 22.12 kB 21.63 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 109.50 kB 106.92 kB = 20.45 kB 19.97 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 109.45 kB 106.87 kB = 20.42 kB 19.95 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 110.64 kB 108.02 kB = 20.51 kB 20.02 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 110.59 kB 107.97 kB = 20.49 kB 20.00 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 151.26 kB 147.61 kB = 35.16 kB 34.18 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 151.23 kB 147.58 kB = 35.13 kB 34.15 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 116.30 kB 113.46 kB = 21.63 kB 21.13 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 116.30 kB 113.46 kB = 21.63 kB 21.13 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 113.73 kB 110.91 kB = 21.17 kB 20.68 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 113.73 kB 110.91 kB = 21.17 kB 20.68 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 123.20 kB 120.07 kB = 22.67 kB 22.11 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 123.20 kB 120.07 kB = 22.67 kB 22.11 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 121.87 kB 118.74 kB = 22.42 kB 21.86 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 121.87 kB 118.74 kB = 22.42 kB 21.86 kB
oss-stable/react-client/cjs/react-client-flight.development.js = 111.07 kB 107.99 kB = 20.12 kB 19.66 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js = 111.05 kB 107.96 kB = 20.10 kB 19.63 kB

Generated by 🚫 dangerJS against 87c367b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mendlero @facebook-github-bot @react-sizebot