Fixup focusability logic of PreparedLayoutTextView #51508
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75103779 |
joevilches
force-pushed
the
export-D75103779
branch
from
6538de3 to
7e9f6e4
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
May 22, 2025
Summary: For now, we are opting to not auto-focus `PreparedLayoutTextViews` if they have links. The reason being this would not work well with Text nested in a View which is also accessible. If that Text had links, and was set to focusable, then TalkBack would individually focus that Text, which users may not want. So this diff removes that link detection, and fixes up accessibility in general. Since this isn't a TextView, we need to explicitly set the `text` on the `AccessibilityNodeInfo` object in the delegate so TalkBack know what to annouce. In the future we aim to bring back auto-focusing with links, but only if a screen reader is not on, so that keyboard users can benefit from this. Changelog: [Internal] Differential Revision: D75103779
|
This pull request was exported from Phabricator. Differential Revision: D75103779 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
May 22, 2025
Summary: Pull Request resolved: facebook#51508 For now, we are opting to not auto-focus `PreparedLayoutTextViews` if they have links. The reason being this would not work well with Text nested in a View which is also accessible. If that Text had links, and was set to focusable, then TalkBack would individually focus that Text, which users may not want. So this diff removes that link detection, and fixes up accessibility in general. Since this isn't a TextView, we need to explicitly set the `text` on the `AccessibilityNodeInfo` object in the delegate so TalkBack know what to annouce. In the future we aim to bring back auto-focusing with links, but only if a screen reader is not on, so that keyboard users can benefit from this. Changelog: [Internal] Differential Revision: D75103779
joevilches
force-pushed
the
export-D75103779
branch
2 times, most recently
from
c967b5c to
7b82a10
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
May 23, 2025
Summary: For now, we are opting to not auto-focus `PreparedLayoutTextViews` if they have links. The reason being this would not work well with Text nested in a View which is also accessible. If that Text had links, and was set to focusable, then TalkBack would individually focus that Text, which users may not want. So this diff removes that link detection, and fixes up accessibility in general. Since this isn't a TextView, we need to explicitly set the `text` on the `AccessibilityNodeInfo` object in the delegate so TalkBack know what to annouce. In the future we aim to bring back auto-focusing with links, but only if a screen reader is not on, so that keyboard users can benefit from this. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75103779
Summary: Pull Request resolved: facebook#51508 For now, we are opting to not auto-focus `PreparedLayoutTextViews` if they have links. The reason being this would not work well with Text nested in a View which is also accessible. If that Text had links, and was set to focusable, then TalkBack would individually focus that Text, which users may not want. So this diff removes that link detection, and fixes up accessibility in general. Since this isn't a TextView, we need to explicitly set the `text` on the `AccessibilityNodeInfo` object in the delegate so TalkBack know what to annouce. In the future we aim to bring back auto-focusing with links, but only if a screen reader is not on, so that keyboard users can benefit from this. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75103779
|
This pull request was exported from Phabricator. Differential Revision: D75103779 |
joevilches
force-pushed
the
export-D75103779
branch
from
7b82a10 to
006d819
Compare
|
This pull request has been merged in d877908. |
|
This pull request was successfully merged by @joevilches in d877908 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For now, we are opting to not auto-focus
PreparedLayoutTextViewsif they have links. The reason being this would not work well with Text nested in a View which is also accessible. If that Text had links, and was set to focusable, then TalkBack would individually focus that Text, which users may not want.So this diff removes that link detection, and fixes up accessibility in general. Since this isn't a TextView, we need to explicitly set the
texton theAccessibilityNodeInfoobject in the delegate so TalkBack know what to annouce.In the future we aim to bring back auto-focusing with links, but only if a screen reader is not on, so that keyboard users can benefit from this.
Changelog: [Internal]
Differential Revision: D75103779