fix: call delete instead of free in imagefetcher #51492
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I've been digging into memleaks in RN for some time and noticed that instances of
FabricUIManager
are leaking on reload action even on an empty app. I managed to pinpoint it to ContextContainer (which holdsFabricUIManager
on the cpp side) not being deallocated after reload. After much much digging (since contextContainer is passed around in many places) I found that destructor ofImageFetcher
never runs on reload, and its instance holdscontextContainer
. It turns out thatImageManager
, which holdsImageFetcher
, was callingfree
instead ofdelete
and the former does not call destructor. After applying it,contextContainer
does not leak makingFabricUIManager
instances not to leak too 🎉.Changelog:
[ANDROID] [FIXED] - Change
free
todelete
to call destructor ofImageFetcher
and releasecontextContainer
.Test Plan:
Run empty RN app in AS, do reload multiple times and see in AS profiler that instances of
FabricUIManager
are kept in memory without this change.