Restore the possibility to extend LayoutAnimationController
#51479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in bca7c5a. |
|
This pull request was successfully merged by @tomekzaw in bca7c5a When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
May 23, 2025
Summary: In #50734, `LayoutAnimationController` was migrated to Kotlin and all of its methods are now marked as final. However, this class is used and extended by `react-native-reanimated` in order to provide Layout Animations for Android on the Old Architecture. With all its methods being marked as final, the builds are failing. This PR restores the possibility to extend `LayoutAnimationController`. ## Changelog: [ANDROID] [FIXED] - Restored the possibility to extend `LayoutAnimationController` Pull Request resolved: #51479 Test Plan: I've checked that this PR fixes build errors caused by `LayoutAnimationController` in react-native-reanimated. Reviewed By: cipolleschi, mdvacca Differential Revision: D75079557 Pulled By: cortinico fbshipit-source-id: beeb700cbad87362dda4b60941124562c4753815
|
This pull request was successfully merged by @tomekzaw in 0dd583f When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #50734,
LayoutAnimationControllerwas migrated to Kotlin and all of its methods are now marked as final.However, this class is used and extended by
react-native-reanimatedin order to provide Layout Animations for Android on the Old Architecture. With all its methods being marked as final, the builds are failing.This PR restores the possibility to extend
LayoutAnimationController.Changelog:
[ANDROID] [FIXED] - Restored the possibility to extend
LayoutAnimationControllerTest Plan:
I've checked that this PR fixes build errors caused by
LayoutAnimationControllerin react-native-reanimated.