Fix disappearing redbox on initial load of an invalid bundle. #50867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 4cc9db1. |
|
This pull request was successfully merged by @aleqsio in 4cc9db1 When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
Summary: Right now having a javascript error like an invalid import statement during first bundle load results in a disappearing redbox screen. https://github.com/user-attachments/assets/ab9c64f5-6e32-481c-a58f-6d37bb920acb The `invalidate` call removed in this PR cleans up all turbomodules, including the RedBox module, which in turns calls `dismiss` in `RCTRedBox`. After removing this line the result is as following: https://github.com/user-attachments/assets/6eeb4d43-f883-440f-ade3-5628f85f833a I made sure that the `invalidate` function is still called when executing only two possible ways to reload the bundle: - the Reload button - Cmd+R The HMR/hot reload is not connected if the bundle has an error on initial load, so we don't need to worry about it. Longer term, it would be better to establish HMR and use a different redbox in this case:  Doing this requires larger changes to the bundle loading flow – happy to to try and land that change if there's any guidance you could give. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS][FIXED] – Fix disappearing redbox on initial load of an invalid bundle. Pull Request resolved: #50867 Test Plan: I have tested this change using RN from main and RNTester app (see videos). Reviewed By: cortinico Differential Revision: D73511154 Pulled By: cipolleschi fbshipit-source-id: dfe149ebc15d845f07fd3926db2e063b468870af
|
This pull request was successfully merged by @aleqsio in 3af9e65 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now having a javascript error like an invalid import statement during first bundle load results in a disappearing redbox screen.
Untitled.mp4
The
invalidatecall removed in this PR cleans up all turbomodules, including the RedBox module, which in turns callsdismissinRCTRedBox.After removing this line the result is as following:
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-04-23.at.13.14.16.mp4
I made sure that the
invalidatefunction is still called when executing only two possible ways to reload the bundle:The HMR/hot reload is not connected if the bundle has an error on initial load, so we don't need to worry about it.
Longer term, it would be better to establish HMR and use a different redbox in this case:
Doing this requires larger changes to the bundle loading flow – happy to to try and land that change if there's any guidance you could give.
Changelog:
[IOS][FIXED] – Fix disappearing redbox on initial load of an invalid bundle.
Test Plan:
I have tested this change using RN from main and RNTester app (see videos).