Migrate to Kotlin - DevSupportManagerBase.kt #50559
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72637098 |
|
This pull request was exported from Phabricator. Differential Revision: D72637098 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 8, 2025
Summary: Pull Request resolved: facebook#50559 This diff migrates the following file to Kotlin - DevSupportManagerBase.kt as part of our ongoing effort of migrating the codebase to Kotlin This file was 1000LOC+ so its migration is quite involved. I had to look into nullability of various parameters. Most notably the `Array<StackFrame?>` -> `Array<StackFrame>`. This also is the last file left in the devsupport package that needs to be migrated to Kotlin. Changelog: [Android] [Breaking] - DevSupportManagerBase is now converted to Kotlin. If you're subclassing this class, you will have to adjust some of the parameters as types have changed during the migration. Differential Revision: D72637098
cortinico
force-pushed
the
export-D72637098
branch
from
c7a3c8e to
355efd6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72637098 |
cortinico
force-pushed
the
export-D72637098
branch
from
355efd6 to
315b741
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 8, 2025
Summary: Pull Request resolved: facebook#50559 This diff migrates the following file to Kotlin - DevSupportManagerBase.kt as part of our ongoing effort of migrating the codebase to Kotlin This file was 1000LOC+ so its migration is quite involved. I had to look into nullability of various parameters. Most notably the `Array<StackFrame?>` -> `Array<StackFrame>`. This also is the last file left in the devsupport package that needs to be migrated to Kotlin. Changelog: [Android] [Breaking] - DevSupportManagerBase is now converted to Kotlin. If you're subclassing this class, you will have to adjust some of the parameters as types have changed during the migration. Differential Revision: D72637098
|
This pull request was exported from Phabricator. Differential Revision: D72637098 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 8, 2025
Summary: Pull Request resolved: facebook#50559 This diff migrates the following file to Kotlin - DevSupportManagerBase.kt as part of our ongoing effort of migrating the codebase to Kotlin This file was 1000LOC+ so its migration is quite involved. I had to look into nullability of various parameters. Most notably the `Array<StackFrame?>` -> `Array<StackFrame>`. This also is the last file left in the devsupport package that needs to be migrated to Kotlin. Changelog: [Android] [Breaking] - DevSupportManagerBase is now converted to Kotlin. If you're subclassing this class, you will have to adjust some of the parameters as types have changed during the migration. Reviewed By: javache, mdvacca Differential Revision: D72637098
cortinico
force-pushed
the
export-D72637098
branch
from
315b741 to
8e956cc
Compare
Summary: This diff migrates the following file to Kotlin - DevServerHelper as part of our ongoing effort of migrating the codebase to Kotlin Changelog: [Internal] [Changed] - DevServerHelper to Kotlin. Differential Revision: D72632266
|
This pull request was exported from Phabricator. Differential Revision: D72637098 |
cortinico
force-pushed
the
export-D72637098
branch
from
8e956cc to
7d856b5
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 9, 2025
Summary: Pull Request resolved: facebook#50559 This diff migrates the following file to Kotlin - DevSupportManagerBase.kt as part of our ongoing effort of migrating the codebase to Kotlin This file was 1000LOC+ so its migration is quite involved. I had to look into nullability of various parameters. Most notably the `Array<StackFrame?>` -> `Array<StackFrame>`. This also is the last file left in the devsupport package that needs to be migrated to Kotlin. Changelog: [Android] [Breaking] - DevSupportManagerBase is now converted to Kotlin. If you're subclassing this class, you will have to adjust some of the parameters as types have changed during the migration. Reviewed By: javache, mdvacca Differential Revision: D72637098
|
This pull request was exported from Phabricator. Differential Revision: D72637098 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 9, 2025
Summary: Pull Request resolved: facebook#50559 This diff migrates the following file to Kotlin - DevSupportManagerBase.kt as part of our ongoing effort of migrating the codebase to Kotlin This file was 1000LOC+ so its migration is quite involved. I had to look into nullability of various parameters. Most notably the `Array<StackFrame?>` -> `Array<StackFrame>`. This also is the last file left in the devsupport package that needs to be migrated to Kotlin. Changelog: [Android] [Breaking] - DevSupportManagerBase is now converted to Kotlin. If you're subclassing this class, you will have to adjust some of the parameters as types have changed during the migration. Reviewed By: javache, mdvacca Differential Revision: D72637098
cortinico
force-pushed
the
export-D72637098
branch
from
7d856b5 to
e20bb8e
Compare
Summary: Pull Request resolved: facebook#50559 This diff migrates the following file to Kotlin - DevSupportManagerBase.kt as part of our ongoing effort of migrating the codebase to Kotlin This file was 1000LOC+ so its migration is quite involved. I had to look into nullability of various parameters. Most notably the `Array<StackFrame?>` -> `Array<StackFrame>`. This also is the last file left in the devsupport package that needs to be migrated to Kotlin. Changelog: [Android] [Breaking] - DevSupportManagerBase is now converted to Kotlin. If you're subclassing this class, you will have to adjust some of the parameters as types have changed during the migration. Reviewed By: javache, mdvacca Differential Revision: D72637098
|
This pull request was exported from Phabricator. Differential Revision: D72637098 |
cortinico
force-pushed
the
export-D72637098
branch
from
e20bb8e to
4a8cac5
Compare
|
This pull request has been merged in 9da485b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff migrates the following file to Kotlin - DevSupportManagerBase.kt
as part of our ongoing effort of migrating the codebase to Kotlin
This file was 1000LOC+ so its migration is quite involved.
I had to look into nullability of various parameters. Most notably the
Array<StackFrame?>->Array<StackFrame>.This also is the last file left in the devsupport package that needs to be migrated to Kotlin.
Changelog:
[Android] [Breaking] - DevSupportManagerBase is now converted to Kotlin. If you're subclassing this class, you will have to adjust some of the parameters as types have changed during the migration.
Differential Revision: D72637098