Convert folly::dynamic event dispatch to r-value #50133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71423497 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 19, 2025
Summary: Allow move semantics for folly::dynamic event dispatching to avoid copying the folly::dynamic when dispatched. ## Changelog [Breaking][Changed] - Dispatch folly::dynamic events with r-value instead of l-value Differential Revision: D71423497
rozele
force-pushed
the
export-D71423497
branch
from
45ff33f to
3b7166f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71423497 |
Summary: Allow move semantics for folly::dynamic event dispatching to avoid copying the folly::dynamic when dispatched. ## Changelog [Breaking][Changed] - Dispatch folly::dynamic events with r-value instead of l-value Differential Revision: D71423497
rozele
force-pushed
the
export-D71423497
branch
from
3b7166f to
ff0885c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71423497 |
|
This pull request has been merged in 12e5df8. |
|
This pull request was successfully merged by @rozele in 12e5df8 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allow move semantics for folly::dynamic event dispatching to avoid copying the folly::dynamic when dispatched.
Changelog
[Breaking][Changed] - Dispatch folly::dynamic events with r-value instead of l-value
Differential Revision: D71423497