Skip to content

TurboModuleWithJSIBindings #50106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

zeyap
Copy link
Contributor

@zeyap zeyap commented Mar 18, 2025

Summary:

Changelog:

[General] [Added] - Create TurboModuleWithJSIBindings interface

So c++ TurboModules can initialize some private members with reference to jsi::Runtime

Differential Revision: D71396842

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71396842

zeyap added a commit to zeyap/react-native that referenced this pull request Mar 18, 2025
Summary:

## Changelog:

[General] [Added] - Create TurboModuleWithJSIBindings interface

So c++ TurboModules can initialize some private members with reference to `jsi::Runtime`

Differential Revision: D71396842
@zeyap zeyap force-pushed the export-D71396842 branch from e9e4456 to 45474c2 Compare March 18, 2025 21:12
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71396842

zeyap added a commit to zeyap/react-native that referenced this pull request Mar 18, 2025
Summary:
Pull Request resolved: facebook#50106

## Changelog:

[General] [Added] - Create TurboModuleWithJSIBindings interface

So c++ TurboModules can initialize some private members with reference to `jsi::Runtime`

Differential Revision: D71396842
@zeyap zeyap force-pushed the export-D71396842 branch from 45474c2 to 08c458b Compare March 18, 2025 21:19
zeyap added a commit to zeyap/react-native that referenced this pull request Mar 18, 2025
Summary:

## Changelog:

[General] [Added] - Create TurboModuleWithJSIBindings interface

So c++ TurboModules can initialize some private members with reference to `jsi::Runtime`

Differential Revision: D71396842
zeyap added a commit to zeyap/react-native that referenced this pull request Mar 18, 2025
Summary:

## Changelog:

[General] [Added] - Create TurboModuleWithJSIBindings interface

So c++ TurboModules can initialize some private members with reference to `jsi::Runtime`

Differential Revision: D71396842
@zeyap zeyap force-pushed the export-D71396842 branch from 08c458b to d6ccfd8 Compare March 18, 2025 21:58
zeyap added a commit to zeyap/react-native that referenced this pull request Mar 18, 2025
Summary:

## Changelog:

[General] [Added] - Create TurboModuleWithJSIBindings interface

So c++ TurboModules can initialize some private members with reference to `jsi::Runtime`

Differential Revision: D71396842
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71396842

@zeyap zeyap force-pushed the export-D71396842 branch from d6ccfd8 to 1881076 Compare March 18, 2025 22:04
zeyap added a commit to zeyap/react-native that referenced this pull request Mar 18, 2025
Summary:
Pull Request resolved: facebook#50106

## Changelog:

[General] [Added] - Create TurboModuleWithJSIBindings interface

So c++ TurboModules can initialize some private members with reference to `jsi::Runtime`

Differential Revision: D71396842
zeyap added a commit to zeyap/react-native that referenced this pull request Mar 19, 2025
Summary:

## Changelog:

[General] [Added] - Create TurboModuleWithJSIBindings interface

So c++ TurboModules can initialize some private members with reference to `jsi::Runtime`

Differential Revision: D71396842
Summary:

## Changelog:

[General] [Added] - Create TurboModuleWithJSIBindings interface

So c++ TurboModules can initialize some private members with reference to `jsi::Runtime`

Reviewed By: lenaic

Differential Revision: D71396842
@zeyap zeyap force-pushed the export-D71396842 branch from 1881076 to 6429d8a Compare March 20, 2025 14:11
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71396842

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 20, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1acd459.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @zeyap in 1acd459

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants