Allow the .pnpm folder to be discovered during code generation #49983
Conversation
…m module crawling.
|
Hi @kirill3333! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 91d0345. |
|
This pull request was successfully merged by @kirill3333 in 91d0345 When will my fix make it into a release? | How to file a pick request? |
Summary: This PR (#48182) introduced skipping hidden folders during Codegen generation. However, when using pnpm, all files are stored in the `.pnpm` folder (see explanation here: https://pnpm.io/symlinked-node-modules-structure). As a result, some libraries that support the new architecture but lack the `ios.codegenConfig.componentProvider` field - like [FlashList](https://github.com/Shopify/flash-list/blob/main/package.json) - will be skipped during Codegen generation. This PR explicitly includes `.pnpm` to prevent this issue. ## Changelog: [iOS][Fixed] - Check .pnpm folder when looking for third-party components. Pull Request resolved: #49983 Test Plan: Tested on: RN 0.78.0 PNPM: 10 Flashlist: 1.7.3 Reviewed By: cipolleschi Differential Revision: D71047936 Pulled By: cortinico fbshipit-source-id: fa9caab23dea8c92ef5f23c997812d348eb19e08
Summary:
This PR (#48182) introduced skipping hidden folders during Codegen generation.
However, when using pnpm, all files are stored in the
.pnpmfolder (see explanation here: https://pnpm.io/symlinked-node-modules-structure).As a result, some libraries that support the new architecture but lack the
ios.codegenConfig.componentProviderfield - like FlashList - will be skipped during Codegen generation.This PR explicitly includes
.pnpmto prevent this issue.Changelog:
[iOS][Fixed] - Check .pnpm folder when looking for third-party components.
Test Plan
Tested on:
RN 0.78.0
PNPM: 10
Flashlist: 1.7.3