Fix TMManager moduleProviderForName #49835
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Summary: The implementation of moduleProviderForName is slightly off. This method was supposed to replace the previous ternary expression and to enhance with the module provider call. The ternary expression used to be ``` !RCTTurboModuleInteropEnabled() || [self _isTurboModule:moduleName] ? [self _provideObjCModule:moduleName] : nil ``` However, as you can see from the current implementation, instead of calling `RCTTurboModuleInteropEnabled()` we are calling `RCTTurboModuleEnabled()` which is clearly a mistake. On top of that, I'm also updating the guard around the `getModuleProvider` selector as it was bypassing the other checks, and that's wrong. ## Changelog: [Internal] - Fix moduleProviderForName method Reviewed By: RSNara Differential Revision: D70569552
|
This pull request was exported from Phabricator. Differential Revision: D70569552 |
|
This pull request was exported from Phabricator. Differential Revision: D70569552 |
cipolleschi
force-pushed
the
export-D70569552
branch
from
e48c23a to
19b483c
Compare
|
This pull request has been merged in 908146c. |
|
This pull request was successfully merged by @cipolleschi in 908146c When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
Summary: Pull Request resolved: #49835 The implementation of moduleProviderForName is slightly off. This method was supposed to replace the previous ternary expression and to enhance with the module provider call. The ternary expression used to be ``` !RCTTurboModuleInteropEnabled() || [self _isTurboModule:moduleName] ? [self _provideObjCModule:moduleName] : nil ``` However, as you can see from the current implementation, instead of calling `RCTTurboModuleInteropEnabled()` we are calling `RCTTurboModuleEnabled()` which is clearly a mistake. On top of that, I'm also updating the guard around the `getModuleProvider` selector as it was bypassing the other checks, and that's wrong. ## Changelog: [Internal] - Fix moduleProviderForName method Reviewed By: RSNara Differential Revision: D70569552 fbshipit-source-id: ed4055da9ea385ed10323ed8d7a8772010b3a105
|
This pull request was successfully merged by @cipolleschi in 2b0e406 When will my fix make it into a release? | How to file a pick request? |
This was referenced Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The implementation of moduleProviderForName is slightly off.
This method was supposed to replace the previous ternary expression and to enhance with the module provider call.
The ternary expression used to be
However, as you can see from the current implementation, instead of calling
RCTTurboModuleInteropEnabled()we are callingRCTTurboModuleEnabled()which is clearly a mistake.On top of that, I'm also updating the guard around the
getModuleProviderselector as it was bypassing the other checks, and that's wrong.Changelog:
[Internal] - Fix moduleProviderForName method
Reviewed By: RSNara
Differential Revision: D70569552