fix: make React native compatible with Ruby 3.4.0 #49293
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Does this still work with older versions of ruby? (I believe CI will tell us that, though...) |
|
Also @okwasniewski, this needs a PR against https://github.com/react-native-community/template as well |
|
@cipolleschi Looks like CI is green! @cortinico Sure, will update the template after merging this one. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in b1735bc. |
|
This pull request was successfully merged by @okwasniewski in b1735bc When will my fix make it into a release? | How to file a pick request? |
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Hey,
This PR fixes compatibility with Ruby 3.4.0 as it removed some libraries from the standard library.
When installing pods I encountered this error:
After adding those dependencies, the error is gone:
Changelog:
[IOS] [FIXED] - Compatibility with Ruby 3.4.0
Test Plan:
Install pods on Ruby 3.4