Fix typos (RCTCustomRefreshControlProtocol)

[jiggag]

Summary

Fix typo RCTCustomRefreshContolProtocol > RCTCustomRefreshControlProtocol

Changelog

[INTERNAL] [FIXED] - Fixed typo RCTCustomRefreshControlProtocol

Test Plan

none

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,517,043	+0
android	hermes	armeabi-v7a	7,833,093	+0
android	hermes	x86	8,997,414	+0
android	hermes	x86_64	8,852,405	+0
android	jsc	arm64-v8a	9,141,055	+0
android	jsc	armeabi-v7a	8,332,938	+0
android	jsc	x86	9,195,853	+0
android	jsc	x86_64	9,453,691	+0

Base commit: 6c208c2
Branch: main

[cipolleschi]

Hi @jiggag, thank you for this PR. Unfortunately, we cannot accept this as it is because changing a type that is widely used is a breaking change. If we release a version of React Native with just this change, we will break every project that uses this component.

The proper way to go is:

1. Create a new protocol with the right name
2. Make the old protocol (with the wrong name) extend the new one (so they are equivalent) and all the existing code that inherit the old one will begin to conform to the new one
3. Mark the old protocol as deprecated (e.g.: https://stackoverflow.com/a/7409545)
4. Go on replacing the internal usages of the old protocol with the new one (as you already did)

Thank you so much for this!

[cortinico]

This is effectively a breaking change that adds really little value imho:
https://cs.github.com/?scopeName=All+repos&scope=&q=RCTCustomRefreshContolProtocol

I know the typo is not cool, but we can't just rename.
@cipolleschi what's your opinion on this?

[cortinico]

Oops I was late 😅 saw your comment above.

[cipolleschi]

As I said above. I will rename it, but not from one day to another.
I'll let the two protocols live for a couple of versions, so that users can be prompted on updating the naming and then we can remove it in 0.74 or 0.75, for example.

[Pranav-yadav]

@cipolleschi I'm not sure if what you suggested is documented or not, but your suggestion above is very informative at least in the context of renaming public APIs.

Provided typo-fix PRs are frequent, I suggest documenting your suggestions above in the Contributing Guide. Glad to open a PR (on react-native-website) for adding those suggestions. Lmk :)

[cipolleschi]

Hi @Pranav-yadav! That would be amazing, although I don't have a clear idea on where it should go.

Probably in the Contributing section of the Website? 🤔
To contribute to the website, you can work on the website repo. ;)

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

/rebase

[cipolleschi]

/rebase

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi merged this pull request in 93c1fbd.