[CodeGen] Add unit test for common parsers method #34915
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 54fc62c |
Base commit: 54fc62c |
|
This is great, thanks! |
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
Oct 10, 2022
|
This pull request was successfully merged by @Naturalclar in cb3a5cc. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This PR is part of facebook#34872 This PR adds unit test for method that were refactored into parsers-commons.js in codegen in facebook#34898 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Add unit test for common parsers method Pull Request resolved: facebook#34915 Test Plan: `yarn jest react-native-codegen` Reviewed By: cipolleschi Differential Revision: D40219036 Pulled By: cipolleschi fbshipit-source-id: 2fb666c016f7822feaf2156d23ce7ffb9572c756
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of #34872
This PR adds unit test for method that were refactored into parsers-commons.js in codegen in #34898
Changelog
[Internal] [Changed] - Add unit test for common parsers method
Test Plan
yarn jest react-native-codegen