Make run-ios --device example copy-pastable #13145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the single quotes to double quotes so this command can easily be copy-pasted. This can be tested by running: react-native run-ios --help and verifying that the "run on device" example is changed: - react-native run-ios --device 'Max's iPhone' + react-native run-ios --device "Max's iPhone"
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
|
@ide has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This import got stuck on an unrelated test failure. Kicking it off again. |
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this pull request
May 7, 2017
Summary: This changes the single quotes to double quotes so this command can be copy-pasted. If a user copy pastes the run-on-device example in bash they will be presented with a confusing prompt because bash expects another terminating single quote. ``` ~ben (master *) ~/code/transit: react-native run-ios --device 'Max's iPhone' > > ``` It seems minor but this could be just confusing enough to frustrate a beginner or someone not familiar with bash. This can be tested by running: ``` react-native run-ios --help ``` and verifying that the "run on device" example is changed: ```diff - react-native run-ios --device 'Max's iPhone' + react-native run-ios --device "Max's iPhone" ``` Closes facebook#13145 Differential Revision: D4776305 Pulled By: hramos fbshipit-source-id: 9500551bfc106cd1687468f7ecc4c91089e1f703
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: This changes the single quotes to double quotes so this command can be copy-pasted. If a user copy pastes the run-on-device example in bash they will be presented with a confusing prompt because bash expects another terminating single quote. ``` ~ben (master *) ~/code/transit: react-native run-ios --device 'Max's iPhone' > > ``` It seems minor but this could be just confusing enough to frustrate a beginner or someone not familiar with bash. This can be tested by running: ``` react-native run-ios --help ``` and verifying that the "run on device" example is changed: ```diff - react-native run-ios --device 'Max's iPhone' + react-native run-ios --device "Max's iPhone" ``` Closes facebook/react-native#13145 Differential Revision: D4776305 Pulled By: hramos fbshipit-source-id: 9500551bfc106cd1687468f7ecc4c91089e1f703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the single quotes to double quotes so this command can be copy-pasted.
Motivation (required)
If a user copy pastes the run-on-device example in bash they will be presented with a confusing prompt because bash expects another terminating single quote.
It seems minor but this could be just confusing enough to frustrate a beginner or someone not familiar with bash.
Test Plan (required)
This can be tested by running:
and verifying that the "run on device" example is changed: