Android inline image width/height is reversed.

[bennyguitar]

This is on master as of issue creation.

You can see the problem right here:

https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageShadowNode.java#L138

[ide]

Anyone want to submit a PR and small test plan?

[Nick177]

Hello, I see that the width and height are reversed in the link provided by "bennyguitar". I am new to React-Native, but I was wondering if I can still help out.

[YuraLaguta]

@ide PR sounds easy, test plan is harder, I would create this textView with some demo image, and then check with Espresso on Android that width and height of view is same as predefined image.
Any suggestions on tests?

[bennyguitar]

@Yurii-Laguta looks like it's already in: c311096

[ide]

A test plan is not quite the same as automated tests. Just providing repro steps and screenshots is helpful.

[bennyguitar]

The test plan should be:

• Create a <Text> component that wraps an <Image> component.
• Make sure the style of the image contains different width and height
• Verify visually that the width/height passed in are respected.

Before this issue, you could pass in width: 20, height: 100 and see the opposite - an image wider than it is tall. With the change, it would be a taller image.

Basically:

<Text>
  <Image source={img} style={{width: 20, height: 100}} />
</Text>

[hoangpham95]

Should be closed as the PR was imported into master: c311096