Skip to content

Remove Apache HTTP dependency #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove Apache HTTP dependency #1049

wants to merge 1 commit into from

Conversation

MGaetan89
Copy link
Contributor

Summary

Apache HTTP classes have been removed from the Android SDK in Android 6.0. Developers needing these classes can add useLibrary 'org.apache.http.legacy' to their Gradle file to keep using that library.
Robolectric now provides shadows for this library in a separate module (org.robolectric:shadows-httpclient), so it is no longer part of the main module.

Changelog

Remove dependency on Apache HTTP.

Test Plan

As per CONTRIBUTING.md, I've ran ./gradlew test, but the task fails with the following message:

* What went wrong:
Execution failed for task ':yoga:buckBuild'.
> execCommand == null!

Note that I have the same result from master.

@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch 3 times, most recently from 16afb25 to 62ab2f8 Compare May 12, 2025 13:58
@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch 11 times, most recently from a4afe92 to 8d1fafb Compare May 22, 2025 14:17
@MGaetan89
Copy link
Contributor Author

I've updated the PR with the latest changes from master and the build is ✅ now.
Let me know if something else is needed for this PR.

@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch 3 times, most recently from 5cb5ee8 to 66a1817 Compare June 1, 2025 14:51
@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch from 66a1817 to fa49a0c Compare June 2, 2025 09:41
@MGaetan89
Copy link
Contributor Author

The PR has been updated with the latest changes from master and it is green again ✅

@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch 3 times, most recently from 9afc477 to 27424fd Compare June 5, 2025 06:42
@MGaetan89 MGaetan89 mentioned this pull request Jun 5, 2025
Closed
@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch 5 times, most recently from d1f8be5 to 4137058 Compare June 12, 2025 07:18
@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch 5 times, most recently from 3798ff6 to a193710 Compare June 19, 2025 10:55
@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch 3 times, most recently from b65d7bf to ae23fcb Compare June 26, 2025 11:03
@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch 3 times, most recently from 6278969 to f57f8a8 Compare July 2, 2025 13:24
@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch 2 times, most recently from e3a272e to 1a0cc84 Compare July 7, 2025 12:36
@MGaetan89
Copy link
Contributor Author

@zielinskimz any chance to have a look at these PRs?

@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch 2 times, most recently from 77f308b to f4a2557 Compare July 15, 2025 08:16
@MGaetan89
Copy link
Contributor Author

@zielinskimz I've updated the PR to include the latest changes from master

@MGaetan89 MGaetan89 force-pushed the remove_apache_http branch from f4a2557 to 9f50876 Compare July 21, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @facebook-github-bot