(Updated again) Flowlint no floating promises #8482
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very exciting - we were talking about wanting this exact linter to use at Khan Academy. It would definitely help us to catch a lot of tricky bugs that would otherwise be nearly impossible to find. We likely won't be able to offer technical support but here is a huge 👍 to seeing this PR and hopefully it getting it merged in someday soon! |
|
What can we do to help move this forward? I think it would be a helpful addition to Flow. |
|
Check out the Flow lint https://beta.flow.org/en/docs/linting/rule-reference/#toc-unused-promise-in-async-scope |
|
This pull request has been merged in d5078fb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another rebase of #8260
There were a lot of nasty merge conflicts, so I just created a new PR instead since I don't think I updated everything correctly.
In practice, this PR seems to work well on our codebase (>100K of Javascript code)
TODO:
type_at_pos_type_destructors.diffasync.diff