Skip to content

docs: fix announcement bar css selector #11262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Conversation

3v0k4
Copy link
Contributor

@3v0k4 3v0k4 commented Jun 12, 2025

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

#10945 changed the class for the announcement bar, which broke the current CSS selector.

Before http://docusaurus.io/:

Screenshot 2025-06-12 at 17 55 30

After https://deploy-preview-11262--docusaurus-2.netlify.app/:

Screenshot 2025-06-12 at 17 55 43

Test Plan

Visit the links above to test the change.

Test links

https://deploy-preview-11262--docusaurus-2.netlify.app/

Related issues/PRs

@3v0k4 3v0k4 requested review from slorber and Josh-Cena as code owners June 12, 2025 15:56
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 12, 2025
Copy link

netlify bot commented Jun 12, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit ca43439
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/684af8b54b98ce0008f2836e
😎 Deploy Preview https://deploy-preview-11262--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 69 🟢 98 🟢 100 🟢 100 Report
/docs/installation 🟠 50 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 71 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 59 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 45 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 60 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 71 🟢 100 🟢 100 🟠 86 Report

@slorber slorber added the pr: ignore This PR is not meaningful enough to appear in the changelog. label Jun 13, 2025
@slorber
Copy link
Collaborator

slorber commented Jun 13, 2025

Thanks, wanted to fix it 😄

@slorber slorber merged commit a392c33 into facebook:main Jun 13, 2025
19 checks passed
@3v0k4 3v0k4 deleted the fix-css branch June 13, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: ignore This PR is not meaningful enough to appear in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants