-
-
Notifications
You must be signed in to change notification settings - Fork 9k
chore: switch to tinyglobby #11042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: switch to tinyglobby #11042
Conversation
⚡️ Lighthouse report for the deploy preview of this PR
|
Report too large to display inline |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I tried to update the PR but tinyglobby seems to introduce problems we don't have with original globby Not sure what is happening but this unit test timeouts in both our CI and on my computer: yarn install
yarn test packages/docusaurus/src/server/translations/__tests__/translationsExtractor.test.ts I can clearly see tinyglobby doesn't return anything and blocks the tests The parameters are: globPaths: [
'../../../../../var/folders/5r/rf5fj2ms2tv4_2fdhcxcnwbm0000gn/T/jest-createTmpSiteDir-45448-tk3qr3eGPkKO/src',
'../../../../../var/folders/5r/rf5fj2ms2tv4_2fdhcxcnwbm0000gn/T/jest-createTmpSiteDir-45448-qOVHltphU5e0/subpath/**/*.{js,jsx,ts,tsx}',
'../../../../../var/folders/5r/rf5fj2ms2tv4_2fdhcxcnwbm0000gn/T/jest-createTmpSiteDir-45448-qOVHltphU5e0/src/theme',
'../../../../../var/folders/5r/rf5fj2ms2tv4_2fdhcxcnwbm0000gn/T/jest-createTmpSiteDir-45448-lpQQgC3uqiBy/subpath/**/*.{js,jsx,ts,tsx}',
'../../../../../var/folders/5r/rf5fj2ms2tv4_2fdhcxcnwbm0000gn/T/jest-createTmpSiteDir-45448-lpQQgC3uqiBy/src/theme'
], Any idea @SuperchupuDev ? |
there's an fdir issue in some cases that makes this hang, the hang isn't common but it can happen. the fix is currently on fdir's main branch, i'm waiting for a release which should hopefully happen this week |
I'll come back to this after the |
Pre-flight checklist
Motivation
https://npmgraph.js.org/?q=globby - 23 dependencies
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies
Test Plan
Rely on existing unit tests since this is a refactor and doesn't add any new functionality
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
Discussed in #11020 (comment)