chore: use rspack 1.3.0 #11039
Merged
chore: use rspack 1.3.0 #11039
+100
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: maintenance
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Report too large to display inline |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +206 B (0%) Total Size: 11.7 MB ℹ️ View Unchanged
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Size Change: -723 B (-0.01%) Total Size: 11.3 MB
ℹ️ View Unchanged
|
|
Seems there's a bug in Reported web-infra-dev/rspack#9834 Waiting for Rspack team to answer before merging |
|
merging and temporarily disabled web-infra-dev/rspack#9834 until fixed By chance 1.3 might also fix some deadlock issues we currently have while bundling (see also web-infra-dev/rspack#9665) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See https://rspack.dev/blog/announcing-1-3
Useful for parallel code splitting, but also support for browserslist/output.environment to reduce output size.
Test Plan
CI
Test links
https://deploy-preview-11039--docusaurus-2.netlify.app/
Benchmarks
Note, I think there's a perf regression between 1.2.5 - 1.2.8, and 1.3 improves things a bit with parallel code splitting.
Doesn't seem big deal to force upgrade to v1.3 though, but I'll try to see why this happens
1.2.5
hyperfine --prepare 'yarn clear:website' --runs 5 'yarn build:website:fast'
Benchmark 1: yarn build:website:fast
Time (mean ± σ): 17.849 s ± 0.254 s [User: 60.544 s, System: 9.482 s]
Range (min … max): 17.474 s … 18.152 s 5 runs
1.2.8
hyperfine --prepare 'yarn clear:website' --runs 5 'yarn build:website:fast'
Benchmark 1: yarn build:website:fast
Time (mean ± σ): 18.747 s ± 0.351 s [User: 60.640 s, System: 9.615 s]
Range (min … max): 18.162 s … 19.031 s 5 runs
1.3.0
hyperfine --prepare 'yarn clear:website' --runs 5 'yarn build:website:fast'
Benchmark 1: yarn build:website:fast
Time (mean ± σ): 18.311 s ± 0.604 s [User: 60.698 s, System: 9.483 s]
Range (min … max): 17.608 s … 19.168 s 5 runs