Enable eslint caching in development #1578
Conversation
POC for facebook#740. Haven't found any problem, build times improved about 1s on my project and machine.
| @@ -118,7 +118,8 @@ module.exports = { | |||
| // Point ESLint to our predefined config. | |||
| options: { | |||
| configFile: path.join(__dirname, '../.eslintrc'), | |||
| useEslintrc: false | |||
| useEslintrc: false, | |||
| cache: true | |||
There was a problem hiding this comment.
We probably don't want this specific setting to be inside of // @remove-on-eject block.
There was a problem hiding this comment.
We'll likely want for this to get merged first: webpack-contrib/eslint-loader#151. Or it will be confusing to ejected users who change the rules.
There was a problem hiding this comment.
Babel falls back to OS tmp dir. Does eslint-loader, too? We should probably use consistent mechanisms. If eslint-loader doesn't, we should send a PR.
There was a problem hiding this comment.
Thanks for the comments! I realized that i'm searching the cache issues in eslint repo rather than eslint-loader repo. I've sent a pr on tmp dir fallback on eslint-loader repo on webpack-contrib/eslint-loader#154. And yup, I think we should wait until webpack-contrib/eslint-loader#151 merged first.
We probably don't want this specific setting to be inside of // @remove-on-eject block.
So, should we move the // @remove-on-eject block. to the inside of the options?
There was a problem hiding this comment.
webpack-contrib/eslint-loader#154 (comment) merged :). Just need to wait webpack-contrib/eslint-loader#151 then.
There was a problem hiding this comment.
It's merged, webpack-contrib/eslint-loader#151 (comment)
There was a problem hiding this comment.
So, should we move the // @remove-on-eject block. to the inside of the options?
Yes I think so.
viankakrisna
force-pushed
the
patch-1
branch
from
c2ed335 to
fb1be9d
Compare
|
Have you tested that this works? |
|
I'm going to trust that this works and ninja-land it. |
😄 This is hilarious, thank you!
Yeah, I tried it by turning off eqeqeq in eslint-config-react-app while the warning still in the terminal, and restart it, the warning's gone. :) |
|
@gaearon @viankakrisna I think this has caused me some problems - Compilation is periodically / intermittently failing with this error: If I save a file compilation passes a second time. I can't find anything relating to this in issues and didn't want to open something in case its me. This is the most recent change that maybe related. I'm using the latest version of Node & NPM. Any suggestions? Thanks |
|
Oh no! That's not good at all, @dylanrhysscott. Could you please open a formal issue and we'll do some triaging to determine if we need to revert this in a release and/or report a bug upstream? Thanks! |
|
@Timer No worries these things happen! :) Will ping you an issue shortly! Thanks |
POC for #740. Haven't found any problem, build times improved about 1s on my project and machine.