Fix unit tests broken by upstream gpytorch changes #1055
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: cornellius-gp/gpytorch#2082 changed the shape of the mean constant (and did some other things). These changes fix the resulting unit test breakages. This requires the botorch change pytorch/botorch#1343 Pull Request resolved: facebook#1055 Reviewed By: lena-kashtelyan Differential Revision: D38527699 Pulled By: Balandat fbshipit-source-id: 86a9a9fb272cebb923e2fafc76fd44624f1069d0
Balandat
force-pushed
the
fix_mean_units
branch
from
c4a6d89 to
90f408f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D38527699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cornellius-gp/gpytorch#2082 changed the shape of the mean constant (and did some other things). These changes fix the resulting unit test breakages.
This requires the botorch change pytorch/botorch#1343